-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] inventory: Delivery Methods #11913
Conversation
905b0bb
to
42c143b
Compare
@larm-odoo this is ready for review. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow- I don't have any changes or suggestions! Sadly, you'll have to re-edit this after you make the new doc, to tag all the places to the new information. But this is great as is- approving!
Thank you Lara! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jero-odoo ! I agree with your decision of splitting the doc, but we shouldn’t publish it as is since users won’t be able to find the shipping method setup info until the new doc is uploaded.
Here’s the plan:
- To ensure the doc is properly split and users can find what they need, we’ll make an exception and modify multiple files in this PR.
- Copy the deleted info into a new doc under delivery methods (no need to improve or edit this yet), then we’ll push this PR. (2 points)
- In a follow-up PR, improve the writing and update it for version 18. (2-3 points)
42c143b
to
491f06b
Compare
Hey @Felicious, I added the new doc with the content and images added back in. I also replaced the links and references that were removed. Let me know if you have any questions. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Ty :D
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jero-odoo! Thank you for your work on this PR. Your changes look good to me! Just a couple small fixes please :)
..
@robodoo delegate=jero-odoo
...s/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/new_delivery_method.rst
Outdated
Show resolved
Hide resolved
...s/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/new_delivery_method.rst
Outdated
Show resolved
Hide resolved
...s/inventory_and_mrp/inventory/shipping_receiving/setup_configuration/new_delivery_method.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Sam Lieber (sali) <[email protected]>
fadbcdf
to
2ae81f0
Compare
@robodoo r+ |
closes #11913 Signed-off-by: Jessica Rogers (jero) <[email protected]> Co-authored-by: Sam Lieber (sali) <[email protected]>
closes #11913 Signed-off-by: Jessica Rogers (jero) <[email protected]> Co-authored-by: Sam Lieber (sali) <[email protected]>
@jero-odoo staging failed: ci/runbot on 25ae776e47257223b596c52c8a5f155c8610fb67 (view more at https://runbot.odoo.com/runbot/build/74323111) |
This staging failed for probably sprurious reasons, we've reset the PR, it should be re-staged soon-ish. |
Docs task: https://www.odoo.com/mail/view?model=project.task&res_id=4454218&access_token=b8742bd7-52ec-4d94-b955-96b6f2c1cc3d
Updated per SME feedback. Removed section on creating a new shipping/delivery method (this information will be added to a new doc)