Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] inventory: Delivery Methods #11913

Closed
wants to merge 1 commit into from

Conversation

jero-odoo
Copy link
Contributor

Docs task: https://www.odoo.com/mail/view?model=project.task&res_id=4454218&access_token=b8742bd7-52ec-4d94-b955-96b6f2c1cc3d

Updated per SME feedback. Removed section on creating a new shipping/delivery method (this information will be added to a new doc)

@jero-odoo jero-odoo self-assigned this Jan 29, 2025
@robodoo
Copy link
Collaborator

robodoo commented Jan 29, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team January 29, 2025 16:38
@jero-odoo jero-odoo force-pushed the 18.0-inventory-delivery-methods-jero branch from 905b0bb to 42c143b Compare January 29, 2025 16:57
@C3POdoo C3POdoo requested a review from a team January 29, 2025 16:59
@jero-odoo
Copy link
Contributor Author

@larm-odoo this is ready for review. Thanks!

Copy link
Contributor

@larm-odoo larm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow- I don't have any changes or suggestions! Sadly, you'll have to re-edit this after you make the new doc, to tag all the places to the new information. But this is great as is- approving!

@jero-odoo
Copy link
Contributor Author

Thank you Lara!
@Felicious this is ready for final.

@jero-odoo jero-odoo requested a review from a team January 29, 2025 18:22
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo ! I agree with your decision of splitting the doc, but we shouldn’t publish it as is since users won’t be able to find the shipping method setup info until the new doc is uploaded.

Here’s the plan:

  • To ensure the doc is properly split and users can find what they need, we’ll make an exception and modify multiple files in this PR.
  • Copy the deleted info into a new doc under delivery methods (no need to improve or edit this yet), then we’ll push this PR. (2 points)
  • In a follow-up PR, improve the writing and update it for version 18. (2-3 points)

@jero-odoo jero-odoo force-pushed the 18.0-inventory-delivery-methods-jero branch from 42c143b to 491f06b Compare January 30, 2025 15:29
@jero-odoo jero-odoo requested a review from Felicious January 30, 2025 15:49
@jero-odoo
Copy link
Contributor Author

Hey @Felicious, I added the new doc with the content and images added back in. I also replaced the links and references that were removed. Let me know if you have any questions. Thanks!

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Ty :D

@jero-odoo
Copy link
Contributor Author

Thank you!
@samueljlieber this is ready for tech review.

@jero-odoo jero-odoo requested a review from a team January 30, 2025 16:09
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo! Thank you for your work on this PR. Your changes look good to me! Just a couple small fixes please :)
..
@robodoo delegate=jero-odoo

Co-authored-by: Sam Lieber (sali) <[email protected]>
@jero-odoo jero-odoo force-pushed the 18.0-inventory-delivery-methods-jero branch from fadbcdf to 2ae81f0 Compare January 31, 2025 20:54
@jero-odoo
Copy link
Contributor Author

@robodoo r+

robodoo pushed a commit that referenced this pull request Feb 1, 2025
closes #11913

Signed-off-by: Jessica Rogers (jero) <[email protected]>
Co-authored-by: Sam Lieber (sali) <[email protected]>
robodoo pushed a commit that referenced this pull request Feb 1, 2025
closes #11913

Signed-off-by: Jessica Rogers (jero) <[email protected]>
Co-authored-by: Sam Lieber (sali) <[email protected]>
@robodoo
Copy link
Collaborator

robodoo commented Feb 1, 2025

@jero-odoo staging failed: ci/runbot on 25ae776e47257223b596c52c8a5f155c8610fb67 (view more at https://runbot.odoo.com/runbot/build/74323111)

@robodoo
Copy link
Collaborator

robodoo commented Feb 3, 2025

This staging failed for probably sprurious reasons, we've reset the PR, it should be re-staged soon-ish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants