[IMP] l10n_cl: enable copy invoice report with legal acknowledgment footer #4822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
…ooter Purpose ------- Support Chilean legal requirements by allowing companies to print a copy of the invoice including an acknowledgment of receipt section. Changes ------- - Added a new report action limited to Chilean companies. - Reused the standard invoice layout with a conditional footer for copies. - Footer includes informationals fields (RUT, Recinto,...) and legal disclaimer. Task-4908875
baje-odoo
force-pushed
the
18.0-rd-accounting-onboarding-l10n_cl-invoice-copy-baje
branch
from
401e505 to
03ae5e7
Compare
malb-odoo
reviewed
Jul 14, 2025
| @@ -0,0 +1,28 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <odoo> | |||
| <template id="report_invoice_copy"> | |||
There was a problem hiding this comment.
usually we prefix the id with the module name
| </template> | ||
|
|
||
| <template id="copy_footer"> | ||
| <div class="mt32" style="border: 2px solid black; padding: 10px;"> |
There was a problem hiding this comment.
Inline styling is not the way to go for multiple reasons, i would even say that it should be avoided at all cost ahah
Reason why:
- Could override existing css rules (example: a class apply the border, by doing the inline styling it will be overriden
- Maintainability: We use Bootstrap or custom odoo classes, let's say we do a revamp of the css code, it will be way easier to check places that use that class, or even if we change a class we want that piece of code to be modified too
- Readbility: inline style is really difficult to read specially when there is many style to add
Comment on lines
+10
to
+25
| <div class="row"> | ||
| <div class="col-6"> | ||
| <p><strong>Nombre:</strong> ______________________________________________</p> | ||
| <p><strong>RUT:</strong> ______________________ <strong>FECHA:</strong> __________________</p> | ||
| <p><strong>Recinto:</strong> __________________ <strong>FIRMA:</strong> ___________________</p> | ||
| </div> | ||
| <div class="col-6"> | ||
| <p style="font-size: 10px;"> | ||
| El acuse de recibo que se declara en este acto, de acuerdo a lo dispuesto en la letra b) del Art. 4º y la letra c) del Art. 5º de la Ley 19.983, acredita que la entrega de mercadería(s) o servicio(s) | ||
| </p> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| <div style="text-align: right;"> | ||
| <strong>CEDIBLE</strong> | ||
| </div> |
| <div class="mt32" style="border: 2px solid black; padding: 10px;"> | ||
| <div class="row"> | ||
| <div class="col-6"> | ||
| <p><strong>Nombre:</strong> ______________________________________________</p> |
There was a problem hiding this comment.
we generally avoid the strong balise and use the fw-bold from bootstap
Comment on lines
+18
to
+19
| El acuse de recibo que se declara en este acto, de acuerdo a lo dispuesto en la letra b) del Art. 4º y la letra c) del Art. 5º de la Ley 19.983, acredita que la entrega de mercadería(s) o servicio(s) | ||
| </p> |
There was a problem hiding this comment.
We usually write those in english and then do the translation with po and pot file
Comment on lines
+225
to
+231
| <template id="report_invoice_document_copy" inherit_id="account.report_invoice_document"> | ||
| <xpath expr="//div[contains(@class, 'page')]" position="after"> | ||
| <t t-if="is_copy"> | ||
| <t t-call="l10n_cl.copy_footer"/> | ||
| </t> | ||
| </xpath> | ||
| </template> |
There was a problem hiding this comment.
instead of an xpath i think that solution is cleaner
There was a problem hiding this comment.
(print with cedible is your is_copy)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Support Chilean legal requirements by allowing companies to print a copy of the invoice including an acknowledgment of receipt section.
Changes
Task-4908875