[IMP] html_builder: Tests for NavbarLinkPopover and MenuDataPlugin #4602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
dabo-odoo
force-pushed
the
master-mysterious-egg-dabo-navbar-popover-tests
branch
2 times, most recently
from
0231f05 to
0b6ae9c
Compare
dabo-odoo
force-pushed
the
master-mysterious-egg-dabo-navbar-popover-tests
branch
from
0b6ae9c to
5934928
Compare
FrancoisGe
reviewed
May 12, 2025
| </ul> | ||
| <p>Outside</p>` | ||
| ); | ||
| await waitFor(".o-we-linkpopover", { timeout: 1500 }); |
There was a problem hiding this comment.
You always need this long timeout ?
There was a problem hiding this comment.
No, it can be completely removed if needed
FrancoisGe
reviewed
May 12, 2025
Comment on lines
30
to
40
| setContent( | ||
| el, | ||
| `<ul class="top_menu"> | ||
| <li> | ||
| <a class="nav-link" href="exists"> | ||
| <span>Top Me[]nu Item</span> | ||
| </a> | ||
| </li> | ||
| </ul> | ||
| <p>Outside</p>` | ||
| ); |
There was a problem hiding this comment.
Another way to set the selection is to use setSelection.
const anchorNode = el.querySelector(".nav-link > span)
setSelection({ anchorNode, anchorOffset: 4})
| @@ -0,0 +1,273 @@ | |||
| import { describe, expect, test } from "@odoo/hoot"; | |||
There was a problem hiding this comment.
move your file in tests/website_builder/
|
|
||
| defineWebsiteModels(); | ||
|
|
||
| describe("Top Menu should open a NavbarLinkPopover", () => { |
| }); | ||
| }); | ||
|
|
||
| describe("should open dialogs when editing link or menu", () => { |
There was a problem hiding this comment.
Maybe use the name of the component
| }; | ||
| }, | ||
| }; | ||
| mockService("orm", fakeORMService); |
There was a problem hiding this comment.
it s not enough to just mock the RPC ? (onRpc)
dabo-odoo
force-pushed
the
master-mysterious-egg-dabo-navbar-popover-tests
branch
from
5934928 to
bb21851
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.