Style ODK-X Survey Instance Savepoints-types#210
Open
juayuohcarineneng19 wants to merge 5 commits intoodk-x:developmentfrom
Open
Style ODK-X Survey Instance Savepoints-types#210juayuohcarineneng19 wants to merge 5 commits intoodk-x:developmentfrom
juayuohcarineneng19 wants to merge 5 commits intoodk-x:developmentfrom
Conversation
Contributor
Author
|
Hi @Redeem-Grimm-Satoshi @wbrunette @maprehensive Please can you review this. |
juayuohcarineneng19
changed the title
Redeem-Grimm-Satoshi
suggested changes
Jul 12, 2024
Comment on lines
633
to
655
| .savepoints.finalized { | ||
| display: flex; | ||
| text-align: center; | ||
| align-items: center; | ||
| width: fit-content; | ||
| padding: 16px; | ||
| justify-content: center; | ||
| color: #1CCB3D; | ||
| background-color: #F0FDF2; | ||
| height: 40px; | ||
| } | ||
|
|
||
| .savepoints.incomplete { | ||
| display: flex; | ||
| text-align: center; | ||
| align-items: center; | ||
| width: fit-content; | ||
| padding: 16px; | ||
| justify-content: center; | ||
| color: #DF961F; | ||
| background-color: #FCF8EA; | ||
| height: 40px; | ||
| } |
Member
There was a problem hiding this comment.
@juayuohcarineneng19 I don't see any border-radius, did you leave this out intentionally?
Those states have a border-radius on the design screen but I can't see it here
Contributor
Author
There was a problem hiding this comment.
@juayuohcarineneng19 I don't see any border-radius, did you leave this out intentionally?
Those states have a border-radius on the design screen but I can't see it here
Hi @Redeem-Grimm-Satoshi I have added border-radius .
Redeem-Grimm-Satoshi
approved these changes
Aug 13, 2024
Member
|
... |
Member
|
@r0ssing Please just go ahead and merge this. Looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approved designs on instance savepoint-types,