address review

oddbird · Feb 23, 2024 · 6da9413 · 6da9413
1 parent b2c49ae
commit 6da9413
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 15 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -114,12 +114,8 @@ export const runSass = function (
   }
 
   // Add the Sass Node.js package importer, if available
-  if (!sassOpts.importers) {
-    try {
-      sassOpts.importers = [new compiler.NodePackageImporter()];
-    } catch (err) {
-      // skip if `NodePackageImporter` isn't available
-    }
+  if (!sassOpts.importers && compiler.NodePackageImporter) {
+    sassOpts.importers = [new compiler.NodePackageImporter()];
   }
 
   const compilerFn =

diff --git a/test/main.test.js b/test/main.test.js
@@ -192,12 +192,13 @@ describe('#runSass', () => {
         {
           ...trueOpts,
           sass: {
-            NodePackageImporter: class {},
-            compile(src, opts) {
-              if (opts.importers[0] instanceof this.NodePackageImporter) {
+            NodePackageImporter: class {
+              constructor() {
                 throw new Error('NodePackageImporter added');
               }
-              throw new Error('failed');
+            },
+            compile() {
+              throw new Error('not added');
             },
           },
         },
@@ -213,20 +214,21 @@ describe('#runSass', () => {
         {
           ...trueOpts,
           sass: {
-            NodePackageImporter: class {},
-            compile(src, opts) {
-              if (opts.importers[0] instanceof this.NodePackageImporter) {
+            NodePackageImporter: class {
+              constructor() {
                 throw new Error('NodePackageImporter added');
               }
-              throw new Error('failed');
+            },
+            compile() {
+              throw new Error('not added');
             },
           },
         },
         '',
         { importers: [] },
       );
     };
-    expect(attempt).to.throw('failed');
+    expect(attempt).to.throw('not added');
   });
 });