Update scripts, controllers, security config, templates, and tests #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates several components of the application to enhance functionality and configuration. Key changes include:
- Enhancements in the test cases to validate search feature behavior and default values.
- Addition of a "Remember Me" checkbox in the login template with corresponding adjustments in the controller.
- Updates to the security configuration to support remember-me functionality with a defined token validity period.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/test/java/net/codejava/JUnit5ExampleTest12.java | New tests added and validation of default values for search and item details. |
| src/main/resources/templates/login.html | Added a "Remember Me" checkbox to the login form. |
| src/main/java/net/codejava/SecurityConfig.java | Integrated remember-me functionality with token validity configuration. |
| src/main/java/net/codejava/AppController.java | Added handling for the "rememberMe" parameter in the login process. |
Files not reviewed (1)
- build_and_run_app.sh: Language not supported
| @Test | ||
| void testMaxRecordsPerPage() { | ||
| System.out.println("Max records per page: " + maxRecordsPerPage); | ||
| assertEquals(20, maxRecordsPerPage, "Max records per page should be 20"); |
There was a problem hiding this comment.
The expected max records per page value (20) is used as a magic number in the test; define a constant (e.g., EXPECTED_MAX_RECORDS) to improve clarity.
| @Test | ||
| void testDefaultItemPrice() { | ||
| System.out.println("Default item price: " + defaultItemPrice); | ||
| assertEquals(999.99, defaultItemPrice, "Default item price should be 999.99"); |
There was a problem hiding this comment.
The expected default item price (999.99) is directly embedded in the assertion; consider defining a constant (e.g., EXPECTED_ITEM_PRICE) to avoid using magic numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the following files:
build_and_run_app.sh: Updated script logic.AppController.java: Modified controller logic.SecurityConfig.java: Adjusted security configurations.login.html: Updated the login template.JUnit5ExampleTest12.java: Enhanced test cases.Please review the changes and provide feedback.