Skip to content

Lwt 6 (NOT FOR MERGE AS IS) #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 59 commits into
base: master
Choose a base branch
from
Draft

Lwt 6 (NOT FOR MERGE AS IS) #1073

wants to merge 59 commits into from

Conversation

raphael-proust
Copy link
Collaborator

No description provided.

raphael-proust and others added 30 commits June 6, 2025 12:29
@raphael-proust
allow multiple schduler to run in parallel
77dcee1 
in separate domains
@raphael-proust
shorter basic multidomain test output
dbe6815
@raphael-proust
addiiotnal multidomain test
cfc7243
@raphael-proust
multidomain tests moving promises and resolvers across domains
288ea06
@raphael-proust
better domainworker test
f88057a
@raphael-proust
tests: terser output, relevant exit codes
802a58a
@raphael-proust
bump dependency to 5.3
76add85
@raphael-proust
don't auto-init domains on main.run
d8d2249 
(at least for now, to be decided later)
@raphael-proust
a bit mroe doc
fb102c5
@raphael-proust
make storage a domain-local thing, allow cross domain cancel
48b9b51 
(untested)

(does this disallow cross domain lwt keys? yes?)
@raphael-proust
replace run_in_main with run_in_domain (and misc imporvements)
836cce7
@raphael-proust
don't double register implicitly
b53a4be
@raphael-proust
some fixes and some deactivate tests
77384ef
@raphael-proust
restore some unix tests
4478ace
@raphael-proust
more refs become atomics
ba710d1
@raphael-proust
remove test-only primitive
e266af5
@c-cube
add the lwt_direct package, for direct-style control flow
cd0e502
@c-cube @raphael-proust
Apply suggestions from code review
7145d61 
Co-authored-by: Raphaël Proust <[email protected]>
@c-cube
some docs
8cab71e
@c-cube
doc
0978471
@c-cube
lwt: expose some storage primitives in Private
5b746aa
@c-cube
lwt_direct: expose basic storage primitives
33527db
@c-cube
add tests for Lwt_direct
b869daa
@c-cube
more tests for Lwt_direct
495852e
@c-cube
CI: see if --best-effort helps
d776f41
@c-cube
CI
dc85027
@c-cube
only test lwt_direct if OCaml >= 5.0
9bee283
@c-cube
fix test on 4.xx
c5aa6c5
@c-cube
dune
cdf51ce
@raphael-proust
some improvements as discussed in PR's review
6e408a8
c-cube and others added 24 commits July 11, 2025 22:07
@c-cube
opam stuff
92c1d3e
@c-cube
tighten a bit Lwt_direct, use Lwt.async_exception_hook
61f338d 
reuse as much as possible from lwt
@c-cube
test: increase coverage
05d3233
@raphael-proust
add TODO in comment
d696674
@raphael-proust
CHAGNELOG
8587e96
@raphael-proust
mark versions in dune file
e133852
@c-cube
rename run to spawn
09fba3a
@raphael-proust
Merge branch 'simon/lwt-direct' into lwt-6
7080eb2 
* simon/lwt-direct:
  rename `run` to `spawn`
@raphael-proust
ocaml.4.14 compat (via domain_shims)
fda2814
@raphael-proust
Merge branch 'domains' into lwt-6
7dd7151 
* domains:
  ocaml.4.14 compat (via domain_shims)
  remove test-only primitive
  more refs become atomics
  restore some unix tests
  some fixes and some deactivate tests
  don't double register implicitly
  replace `run_in_main` with `run_in_domain` (and misc imporvements)
  make storage a domain-local thing, allow cross domain cancel
  a bit mroe doc
  don't auto-init domains on main.run
  bump dependency to 5.3
  tests: terser output, relevant exit codes
  better domainworker test
  multidomain tests moving promises and resolvers across domains
  addiiotnal multidomain test
  shorter basic multidomain test output
  allow multiple schduler to run in parallel
@raphael-proust
make lwt-direct compatible with multi-domain
392336e 
known bug: one of the direct-style test does not terminate, hangs on
`Lwt_io.close`
@raphael-proust
also run CI on 4.14
1d89906
@raphael-proust
trying to fix the notification system
65f8ebd
@raphael-proust
fix jobs' domain_id not being initialised
51236bd
@raphael-proust
restore windows (untested)
2027bc1
@raphael-proust
more fix windows
f56fcce
@raphael-proust
clean-up unneeded flag
aa442e2
@raphael-proust
Merge pull request #1064 from ocsigen/lwt-6-draft
3dfa600 
Fix notifications for jobs
@raphael-proust
prepare for 6alpha01
7fe46b8
@raphael-proust
additional test for multidomain: pipe communications
ab07965
@raphael-proust
Merge branch 'master' into lwt-6
9bd9f9d 
* master: (26 commits)
  import recent CHANGES
  dune-project fixes from 5.[89].1
  make fPIC/pthread flags unix-specific
  workflow needs only to not really be only
  fix typo in dummy package name
  warning suppression that's supported by more compiler versions
  suppress warning
  fix unix compilation
  restore lwt_ppx compatible with ocaml4
  improve maintainability of github action
  only do ppx with 5.1+
  Bump actions/checkout from 4 to 5
  changes go into 5.10
  trying to force the CI's hand installing the right version of let_ppx
  changelog
  add doc for set_tcp_nodelay in Lwt_io
  rollback some cosmetic-only changes
  more docs
  Update src/unix/lwt_io.mli
  _
  ...
@raphael-proust
remove coverage/bisect
3142c9e
@raphael-proust
test/direct: use test stanza so executable is associated to pkg
6568544 
use `build_if`  rather than `enabled_if`
@raphael-proust
adapt workflow to mish mash of compatibility to ocaml versions
b06ed14
@raphael-proust
Copy link
Collaborator Author

Compatibility issues:

  • Lwt_preemptive.run_in_main replaced by Lwt_preemptive.run_in_domain.

    • Should we still provide a run_in_main which makes assumption about a default domain? The main purpose would be to allow old applications to keep working in a single-domain way. And for that it'd make sense. Although it's worrying that some code written for multi-domain Lwt specifically might be using run_in_main accidentally. Maybe a runtime check that crashes run_in_main if there are more than one scheduler running or some other such condition.

  • Lwt_unix.*notification* now take an additional Domain.id parameter. Same suggestion as Lwt_preemptive.run.

    • Should we offer automatic migration (ocamlmig or other) to add Domain.self as a parameter?

  • Lwt_unix.run removal: it's been deprecated for a long time in favour of Lwt_main.run (it can't be kept because it'd create circular dependencies.

    • Should we offer automatic migration?

  • Lwt_engine.fake_event removal: ACTUALLY LETS RESTORE IT

  • Lwt_main.*hooks* removal: deprecated, exposed inernal implementation detail which is incompatible with new implementation. Should be replaced by uses of corresponding submodules.

    • Should we offer automatic migration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphael-proust @c-cube