Skip to content

Conversation

raphael-proust
Copy link
Collaborator

@raphael-proust raphael-proust commented Mar 7, 2025

  • add explicit version field
  • incompatible with ppxlib.0.36.0

@raphael-proust raphael-proust mentioned this pull request Mar 7, 2025
dune-project Outdated
@@ -26,10 +26,11 @@

(package
(name lwt_ppx)
(version dev)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it mostly because then it's easier to remember to set the version field when doing a release. Otherwise I have to remember to add the version field which I'm likely to forget.

Probably should just write a release script, but in the meantime I'd rather have that.

@raphael-proust raphael-proust force-pushed the backport-fixes-from-recent-releases branch from 7c8c1f1 to 6799fa9 Compare August 22, 2025 12:27
@raphael-proust raphael-proust merged commit 5349dd2 into master Aug 22, 2025
50 of 53 checks passed
@smorimoto smorimoto deleted the backport-fixes-from-recent-releases branch August 22, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants