Implementation of effects based on the Stack Switching proposal #1832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vouillon
force-pushed
the
native-effects
branch
10 times, most recently
from
49e1043 to
f368877
Compare
vouillon
force-pushed
the
native-effects
branch
13 times, most recently
from
3b9ce6d to
3f4555c
Compare
vouillon
force-pushed
the
native-effects
branch
2 times, most recently
from
a8763e2 to
4d6ce8e
Compare
vouillon
force-pushed
the
native-effects
branch
3 times, most recently
from
5c5211c to
41291bc
Compare
vouillon
force-pushed
the
native-effects
branch
5 times, most recently
from
2fd57df to
226063f
Compare
vouillon
force-pushed
the
native-effects
branch
from
5e8405e to
83474da
Compare
vouillon
force-pushed
the
native-effects
branch
5 times, most recently
from
0017456 to
c27e0c1
Compare
vouillon
force-pushed
the
native-effects
branch
from
c27e0c1 to
13e9b8f
Compare
Wasmtime only supports these instructions. We should eventually use instead of the legacy instructions, but they are not allowed by default in node.
vouillon
force-pushed
the
native-effects
branch
from
13e9b8f to
9396373
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To generate Wasm code that makes use of the Stack Switching proposal, you first need to install the development version of Binaryen (or version 124 once it is released).
Then, you need to run
wasm_of_ocamlwith the--enable wasiflag:This produces some Wasm code that can be directly executed by the Wizard engine:
Note that we keep the same output convention, at least for now: a JavaScript file
foo.jsand a directoryfoo.assetscontaining the Wasm code. The JavaScript file should be useful to run the tests withnodeonce it supports this extension. It is used at the moment in #1831 to test the WASI runtime.