Skip to content

Hints phys equal #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: hints
Choose a base branch
from
Draft

Hints phys equal #1745

wants to merge 8 commits into from

Conversation

hhugo
Copy link
Member

@hhugo hhugo commented Nov 25, 2024 •
edited
Loading

Fix #1372

@hhugo hhugo mentioned this pull request Nov 25, 2024
Closed
@TyOverby
Copy link
Collaborator

There's a lot of unexpected changes in this PR, I think you may need to rebase it?

@hhugo
Copy link
Member Author

hhugo commented Nov 25, 2024

This PR is based on #1721

@hhugo hhugo marked this pull request as draft November 25, 2024 16:47
@smorimoto smorimoto changed the base branch from master to hints November 28, 2024 13:08
@smorimoto
Copy link
Member

Now, when you merge the hints branch, this PR will automatically be directed to master branch.

@hhugo hhugo mentioned this pull request Dec 9, 2024
Open
7 tasks
@smorimoto smorimoto requested a review from Copilot December 29, 2024 20:08
Copilot
Copilot AI reviewed Dec 29, 2024
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • compiler/lib/generate.ml: Language not supported
  • compiler/lib/parse_bytecode.ml: Language not supported

@hhugo hhugo force-pushed the hints branch 4 times, most recently from 9bfa44e to 96fe9c4 Compare June 17, 2025 09:04
@hhugo hhugo force-pushed the hints-phys-equal branch 2 times, most recently from f16ba36 to 33dd2ff Compare June 17, 2025 12:36
@hhugo hhugo force-pushed the hints-phys-equal branch from 33dd2ff to 4d9bc01 Compare June 20, 2025 12:10
@hhugo hhugo force-pushed the hints-phys-equal branch from 4d9bc01 to 84805d4 Compare July 7, 2025 10:18
@hhugo hhugo force-pushed the hints-phys-equal branch from 84805d4 to 36b0712 Compare July 7, 2025 11:26
@hhugo hhugo force-pushed the hints-phys-equal branch from 36b0712 to 85b6cbf Compare July 9, 2025 10:45
@vouillon vouillon force-pushed the hints branch 2 times, most recently from 644071b to e2ac120 Compare September 17, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Object.is instead of === to implement phys_equal
3 participants
@hhugo @TyOverby @smorimoto