Skip to content

Conversation

Aniak5
Copy link
Contributor

@Aniak5 Aniak5 commented Jan 8, 2025

Related Issue:

#1306

Description of changes:

  • Add protocol_name and command to email activity event class
  • Addto_mailboxes/from_mailbox/cc_mailboxes/delivered_to_list/reply_to_mailboxes to email object
  • Deprecate smpt_to/smtp_from/smtp_hello/delivered_to/reply_to
  • Update banner description to be more generic
image image

@Aniak5 Aniak5 added network_activity Issues related to Network Activity Category breaking Any breaking, non backwards compatible changes labels Jan 8, 2025
@Aniak5 Aniak5 self-assigned this Jan 8, 2025
@Aniak5 Aniak5 marked this pull request as draft January 8, 2025 17:56
@Aniak5 Aniak5 marked this pull request as ready for review January 10, 2025 15:48
@Aniak5 Aniak5 changed the title DRAFT: Make Email Activity event class and email object more generic Issue-1306: Make Email Activity event class and email object more generic Jan 10, 2025
@Aniak5
Copy link
Contributor Author

Aniak5 commented Jan 10, 2025

@JW-Corelight, @zschmerber @mikeradka do we want to add similar *_details fields for reply_to and delivered_to?

@JW-Corelight
Copy link
Contributor

It looks like you're right that both reply_to and delivered_to have the same issue - they can contain both the display name and the routable email address, so it make sense for them to have the *_details fields as well

@Aniak5 Aniak5 added non_breaking Non Breaking, backwards compatible changes and removed breaking Any breaking, non backwards compatible changes labels Jan 10, 2025
@JW-Corelight JW-Corelight self-requested a review January 10, 2025 19:46
JW-Corelight
JW-Corelight previously approved these changes Jan 10, 2025
@floydtree floydtree added the v1.4.0 Changes marked for the upcoming version 1.4.0 label Jan 14, 2025
Aniak5 and others added 21 commits January 22, 2025 15:00
Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
…ailbox plural for arrays

Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
…vered_to_list' and 'reply_to_mailboxes'

Signed-off-by: Ania Kacewicz <[email protected]>
Copy link
Contributor

@pagbabian-splunk pagbabian-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor point - for message_uid we should also use the Source meta data keyword for "Message-ID"

@floydtree
Copy link
Contributor

There is a breaking change (hardening requirement of activity_id) in this PR that the community collectively agreed to pass through. All 3 Email Activity * star classes had a bug since v1.0.0, where it had overwritten activity_id's requirement from required to optional in its definition.

This directly conflicts with usage of activity_id throughout the framework, as it is one of the primary classifiers in all event classes and is expected to be populated in all OCSF events. The has community collectively agreed to fix this within the v1 major cycle, even though this can technically be classified as a breaking change considering it as a critical bugfix.

@pagbabian-splunk @Aniak5 @mikeradka @jasonbreimer

@floydtree floydtree merged commit 3827752 into ocsf:main Jan 24, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Any breaking, non backwards compatible changes bug Something isn't working deprecation A schema artifact is being deprecated network_activity Issues related to Network Activity Category v1.4.0 Changes marked for the upcoming version 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants