-
Notifications
You must be signed in to change notification settings - Fork 168
Issue-1306: Make Email Activity
event class and email
object more generic
#1307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Email Activity
event class and email
object more genericEmail Activity
event class and email
object more generic
@JW-Corelight, @zschmerber @mikeradka do we want to add similar |
It looks like you're right that both |
Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
…l object Signed-off-by: Ania Kacewicz <[email protected]>
…lbox Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
…bject Signed-off-by: Ania Kacewicz <[email protected]>
…ailbox plural for arrays Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
…vered_to_list' and 'reply_to_mailboxes' Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
…descriptions Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
…ent classes Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor point - for message_uid
we should also use the Source
meta data keyword for "Message-ID"
Signed-off-by: Ania Kacewicz <[email protected]>
There is a breaking change (hardening requirement of activity_id) in this PR that the community collectively agreed to pass through. All 3 Email Activity * star classes had a bug since v1.0.0, where it had overwritten This directly conflicts with usage of |
Related Issue:
#1306
Description of changes:
protocol_name
andcommand
to email activity event classto_mailboxes
/from_mailbox
/cc_mailboxes
/delivered_to_list
/reply_to_mailboxes
to email objectsmpt_to/smtp_from/smtp_hello/delivered_to/reply_to
banner
description to be more generic