Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add root-modules field #157

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Add root-modules field #157

merged 3 commits into from
Jun 10, 2024

Conversation

ryndubei
Copy link
Collaborator

@ryndubei ryndubei commented Jun 8, 2024

Fixes #40

This adds a root-modules field, which marks all exports of a module as roots.

Currently the exports marked as roots do not include any exported instances, as that is the simplest option. A possible alternative is to consider which instances would be accessible by someone importing the root module (e.g. if both the class and the datatype are exported).

The implementation re-adds analyseExport to Weeder.hs, but rewritten to be compatible with GHC 9.8.

Copy link
Owner

@ocharles ocharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@ryndubei ryndubei merged commit 5f23719 into ocharles:master Jun 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow using (specific) module export lists as roots
2 participants