Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid cli to exit, loop commands #99

Merged
merged 9 commits into from
Mar 26, 2025
Merged

avoid cli to exit, loop commands #99

merged 9 commits into from
Mar 26, 2025

Conversation

paulo-ocean
Copy link
Contributor

Fixes #95

Changes proposed in this PR:

  • keep CLI running & waiting for input commands

@paulo-ocean paulo-ocean self-assigned this Mar 18, 2025
@paulo-ocean paulo-ocean marked this pull request as ready for review March 26, 2025 10:50
jamiehewitt15
jamiehewitt15 approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could consider adding a test for this. But otherwise, looks good

@paulo-ocean paulo-ocean merged commit 8893bad into main Mar 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent Ocean.cli to exit after each command
2 participants
@paulo-ocean @jamiehewitt15