Clean all created temporary files at exit #6695
Conversation
| val with_tmp_dir_job: (Dir.t -> 'a OpamProcess.job) -> 'a OpamProcess.job | ||
|
|
||
| (** Raw function to create a temporary directory. No automatic cleanup *) | ||
| (** Raw function to create a temporary directory. |
There was a problem hiding this comment.
These mk_* functions are misleading, they do not create anything but merely return a unique name. I think we should change this first
There was a problem hiding this comment.
good point. Especially with https://github.com/ocaml/opam/pull/6659/files#diff-38a34666fa25190dcc42466d8decbd8c6d5bb62952d05b09f0d233c37b3bd4d7R320 we have a case where we don't want to clean the temporary file, we should have both functions.
There was a problem hiding this comment.
As discussed, there is indeed no need to have the non cleaned temporary files for opamfile variable as we stay in opam.
There was a problem hiding this comment.
These mk_* functions are misleading, they do not create anything but merely return a unique name. I think we should change this first
I've opened #6704 for that
src/core/opamFilename.ml
Outdated
| if exists filename then Some filename else None | ||
|
|
||
| let mk_tmp_file () = | ||
| of_string @@ OpamSystem.mk_temp_dir () |
There was a problem hiding this comment.
creating new files by ""creating a directory"" feels a bit wrong
There was a problem hiding this comment.
It is because it is non well named, as you pointed on your previous message.
| if Sys.file_exists d then | ||
| Unix.rmdir d; |
There was a problem hiding this comment.
The check is redundant with the try ... with Unix_error _ block
| if Sys.file_exists d then | |
| Unix.rmdir d; | |
| Unix.rmdir d; |
2 participants
No description provided.