Skip to content

Conversation

tjammer
Copy link
Contributor

@tjammer tjammer commented Oct 8, 2025

CHANGES:

  • Upgrade dependency patch to 3.0.0
  • Correctly set glyph_count in Font.set_glyphs
  • Export Raylib_c module
  • Upgrade to raylib 5.5

CHANGES:

* Upgrade dependency patch to 3.0.0
* Correctly set `glyph_count` in `Font.set_glyphs`
* Export `Raylib_c` module
* Upgrade to raylib 5.5
@tjammer
Copy link
Contributor Author

tjammer commented Oct 8, 2025

The fails on FreeBSD are due to the gl package. The name seems to be wrong, but this has been the case in the last few releases as well.

The windows (msys) failure is new.

  # make: x86_64-w64-mingw32-ar: No such file or directory
  # make: *** [Makefile:718: raylib] Error 127

How is the archiver called in msys? Just ar? I might have to use a different setup/patch for msys. Can we detect msys2? Currently, the dune file uses

(enabled_if
(= %{system} mingw64))

@jmid
Copy link
Member

jmid commented Oct 8, 2025

The windows (msys) failure is new.

  # make: x86_64-w64-mingw32-ar: No such file or directory
  # make: *** [Makefile:718: raylib] Error 127

How is the archiver called in msys? Just ar?

I think so. 🤔
Some digging reveals a /mingw64/bin/ar.exe entry at the bottom of https://packages.msys2.org/packages/mingw-w64-x86_64-binutils

I might have to use a different setup/patch for msys. Can we detect msys2?

In opam packages it is detected using os = "win32" & os-distribution = "msys2" (ignoring a 64/32-bit distinction).

Since https://github.com/ocaml/dune/releases/tag/3.20.0 with ocaml/dune#11863
it should be possible to express the equivalent condition in dune.

* Fix constness of ptr argument to `GuiListViewEx`
* Distingish msys and other mingw environments
@tjammer
Copy link
Contributor Author

tjammer commented Oct 14, 2025

I would've expected this filter to apply to the msys2 version but it's still applying the mingw64 patch

@jmid
Copy link
Member

jmid commented Oct 15, 2025

I would've expected this filter to apply to the msys2 version but it's still applying the mingw64 patch

I agree that it is strange. Could you add a debug print of the variable's value?
My suggestions are based on https://github.com/ocaml/opam-repository/wiki/Depexts-os-distribution---os-family-values
from #25484 (comment)
These are all opam variables though - not dune ones.
For one I can see os-distribution (in opam) is named os_distribution (in dune)
from ocaml/dune#11863 and that dune doesn't seem to use quoted strings for these.

Based on the above I'd also be curious whether both system and os_distribution hold the values we expect... 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants