Skip to content

Conversation

tmcgilchrist
Copy link
Contributor

@tmcgilchrist tmcgilchrist force-pushed the release-runtime_events_tools-0.5.3 branch from 8f568fe to e314bed Compare September 7, 2025 22:30
@tmcgilchrist
Copy link
Contributor Author

Previously this was not installable on Windows, I've updated the available field to reflect that.
It should be usable on any Unix platform, there hasn't been much testing on Windows so I'm keeping that restriction.

@jmid
Copy link
Contributor

jmid commented Sep 10, 2025

On commit 8f568fe I saw runtime_events_tools_bare.0.5.3 compiling cleanly on the Windows CI:
https://github.com/ocaml/opam-repository/actions/runs/17505790089/job/49728939921
(The full version in runtime_events_tools.0.5.3 was indeed failing! ❌)
If the cut-down version works, I see no need to exclude Windows users (I don't recall whether there are unix'isms required to run it though) 🤷

Would you consider adding x-maintenance-intent entries?
https://github.com/ocaml/opam-repository/blob/master/governance/policies/archiving.md

@tmcgilchrist
Copy link
Contributor Author

@jmid It wont work on Windows, the native dependency hdr_histogram_ocaml fails to build.
(See tarides/runtime_events_tools#65).

I don't have the hardware or time to test on Windows. If someone wants to help out please submit a PR.

Maintenance intent should be x-maintenance-intent: ["(latest)"]

@jmid
Copy link
Contributor

jmid commented Sep 17, 2025

@jmid It wont work on Windows, the native dependency hdr_histogram_ocaml fails to build. (See tarides/runtime_events_tools#65).

I think we are misunderstanding each other:
On https://github.com/ocaml/opam-repository/actions/runs/17505790089/job/49728939921

  • runtime_events_tools_bare.0.5.3 which only depends on dune, ocaml, and cmdliner built succesfully. It doesn't depend on hdr_histogram_ocaml.
  • I agree that runtime_events_tools.0.5.3 fails to build because its dependency hdr_histogram 0.0.4 fails to build on Windows.

Hence my comment:

If the cut-down version works, I see no need to exclude Windows users (I don't recall whether there are unix'isms required to run it though) 🤷

Maintenance intent should be x-maintenance-intent: ["(latest)"]

Excellent, thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants