Skip to content

[new release] fpath-sexp0 and fpath-base (0.3.0) #27908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

mbarbin
Copy link
Contributor

@mbarbin mbarbin commented May 21, 2025

CHANGES:

Added

Deprecated

  • Deprecate Fpart - renamed Fsegment and available since 0.2.2.

@mbarbin mbarbin marked this pull request as ready for review May 21, 2025 08:32
@ivnhk
Copy link

ivnhk commented May 21, 2025

@mbarbin thank you for your contribution

I see the following errors on CI:

ERROR] The compilation of fpath-sexp0.0.3.0 failed at "dune build -p fpath-sexp0 -j 71 @install".

#=== ERROR while compiling fpath-sexp0.0.3.0 ==================================#
# context              2.3.0 | linux/x86_64 | ocaml-options-only-flambda.1 | pinned(https://github.com/mbarbin/fpath-base/releases/download/0.3.0/fpath-base-0.3.0.tbz)
# path                 ~/.opam/4.14/.opam-switch/build/fpath-sexp0.0.3.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p fpath-sexp0 -j 71 @install
# exit-code            1
# env-file             ~/.opam/log/fpath-sexp0-7-1747db.env
# output-file          ~/.opam/log/fpath-sexp0-7-1747db.out
### output ###
# (cd _build/default && /home/opam/.opam/4.14/bin/ocamlopt.opt -w -40 -w +a-4-40-41-42-44-45-48-66 -warn-error +a -g -I lib/fpath_sexp0/src/.fpath_sexp0.objs/byte -I lib/fpath_sexp0/src/.fpath_sexp0.objs/native -I /home/opam/.opam/4.14/lib/fpath -I /home/opam/.opam/4.14/lib/sexplib0 -intf-suffix .ml -no-alias-deps -open Fpath_sexp0__ -o lib/fpath_sexp0/src/.fpath_sexp0.objs/native/fpath_sexp0__Fpath0.cmx -c -impl lib/fpath_sexp0/src/fpath0.ml)
# File "_none_", line 1:
# Error (warning 58 [no-cmx-file]): no cmx file was found in path for module Astring_string, and its interface was not compiled with -opaque

The error is happening for ocaml-4.14-flambda and ocaml-4.14-flambda-fp

@shonfeder
Copy link
Contributor

@mbarbin since this is limited to just the flambda variants on an older OCaml, and since it does not seem to be related to any code in your package, I am going to ignore the error here.

I suspect it is an upstream problem in any case.

Thanks for publishing your updates!

@shonfeder shonfeder merged commit 5c86c59 into ocaml:master May 21, 2025
2 of 3 checks passed
@mbarbin
Copy link
Contributor Author

mbarbin commented May 21, 2025

Thanks @ivnhk and @shonfeder for looking into the PR !

I have a vague feeling this may be related to this issue ocaml/dune#11212 and the fact that the package has (implicit_transitive_deps false).

I am going to comment further on the dune issue to ask for more details. At any rate, I don't think that having merged as is will cause harm. Thanks a lot!

@mbarbin mbarbin deleted the fpath-sexp0 branch May 21, 2025 19:43
@mbarbin
Copy link
Contributor Author

mbarbin commented May 22, 2025

I have a vague feeling this may be related to this issue ocaml/dune#11212 and the fact that the package has (implicit_transitive_deps false).

I was wrong. The error was most likely due to the same reasons as in this other pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants