Skip to content

Package binaryen.0.26.0 #27894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025
Merged

Conversation

grainbot
Copy link
Contributor

binaryen.0.26.0

OCaml bindings for Binaryen



0.26.0 (2025-05-17)

⚠ BREAKING CHANGES

  • Upgrade to Binaryen v116 (#202)

Features


🐫 Pull-request generated by opam-publish v2.4.0

@ivnhk
Copy link

ivnhk commented May 19, 2025

For this one, the compilation of libbinaryen.116.0.0 failed on archlinux-ocaml-4.14 AND archlinux-ocaml-5.3. Not exactly sure why

Windows build is also failing. Do you support Windows?

@raphael-proust
Copy link
Contributor

The windows failure is

  #=== ERROR while compiling libbinaryen.116.0.0 ================================#
  # context     2.3.0 | win32/x86_64 | ocaml.5.3.0 | file://D:/a/opam-repository/opam-repository
  # path        D:\opamroot\default\.opam-switch\build\libbinaryen.116.0.0
  # command     D:\opamroot\default\bin\dune.exe build -p libbinaryen -j 3
  # exit-code   1
  # env-file    D:\opamroot\log\libbinaryen-2644-22e571.env
  # output-file D:\opamroot\log\libbinaryen-2644-22e571.out
  ### output ###
  # CMake Error at /usr/share/cmake-3.28.3/Modules/CMakeTestCCompiler.cmake:67 (message):
  # [...]
  #     gmake: *** [Makefile:127: cmTC_8c1a5/fast] Error 2
  #     
  #     
  # 
  #   
  # 
  #   CMake will not be able to correctly generate this project.
  # Call Stack (most recent call first):
  #   CMakeLists.txt:10 (project)
  # 
  # 

which is a bit obscure as error messages go :head-scratch:


The error on Arch seems to be

# cc1plus: all warnings being treated as errors

and a bunch of warnings. My guess is that Arch packs a different version of the compiler (or some other part of tooling) and there is a different set of warnings available, or a different defaut w.r.t. what warnings are enabled, or something like that.

Idk that you should have "all warnings as errors" for release. FWIW, dune's release profile treats almost no warnings as errors.

@raphael-proust
Copy link
Contributor

ping @ospencer

@ospencer
Copy link
Contributor

For the Windows issues, we're aware of them and made some changes that we think will resolve them for the opam CI, but those aren't included until libbinaryen v122. Windows does pass our CI, though, setting the compiler: https://github.com/grain-lang/binaryen.ml/actions/runs/15084793354/job/42405983396

The arch build is a bummer. We won't be able to resolve that until libbinaryen 122/123. We technically don't need binaryen.ml versions with the intermediate libbinaryen versions, but it's nice to be able to have versions with the different Binaryen majors. Is this a total blocker?

@ivnhk
Copy link

ivnhk commented May 21, 2025

@raphael-proust @shonfeder ping

@shonfeder
Copy link
Contributor

@ospencer is this meant to supersede #27893, or are both versions needed?

@ospencer
Copy link
Contributor

No, both are needed.

@mseri
Copy link
Member

mseri commented May 26, 2025

Seems to be in line with previous releases. Thanks

@mseri mseri merged commit 9cf91be into ocaml:master May 26, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants