-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Package binaryen.0.26.0 #27894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package binaryen.0.26.0 #27894
Conversation
For this one, the compilation of Windows build is also failing. Do you support |
The windows failure is
which is a bit obscure as error messages go :head-scratch: The error on Arch seems to be
and a bunch of warnings. My guess is that Arch packs a different version of the compiler (or some other part of tooling) and there is a different set of warnings available, or a different defaut w.r.t. what warnings are enabled, or something like that. Idk that you should have "all warnings as errors" for release. FWIW, dune's release profile treats almost no warnings as errors. |
ping @ospencer |
For the Windows issues, we're aware of them and made some changes that we think will resolve them for the opam CI, but those aren't included until libbinaryen v122. Windows does pass our CI, though, setting the compiler: https://github.com/grain-lang/binaryen.ml/actions/runs/15084793354/job/42405983396 The arch build is a bummer. We won't be able to resolve that until libbinaryen 122/123. We technically don't need binaryen.ml versions with the intermediate libbinaryen versions, but it's nice to be able to have versions with the different Binaryen majors. Is this a total blocker? |
No, both are needed. |
Seems to be in line with previous releases. Thanks |
binaryen.0.26.0
OCaml bindings for Binaryen
0.26.0 (2025-05-17)
⚠ BREAKING CHANGES
Features
🐫 Pull-request generated by opam-publish v2.4.0