Skip to content

cohttp & uri: add x-maintenance-intent from upstream #27571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Mar 6, 2025

@mseri
Copy link
Member

mseri commented Mar 6, 2025

I have left a question on cohttp, I'd wait for the answer before merging this

@mseri mseri added the question label Mar 6, 2025
@raphael-proust
Copy link
Contributor

@hannesm
Copy link
Member Author

hannesm commented Apr 6, 2025

/cc @samoht -- would be great if you could approve or disapprove

@smorimoto smorimoto requested a review from samoht April 17, 2025 04:07
@hannesm
Copy link
Member Author

hannesm commented Apr 28, 2025

Paging @samoht for his opinion about this.

@samoht
Copy link
Member

samoht commented Apr 28, 2025

I've checked with @rgrinberg and it's ok to drop support for old versions of cohttp

@hannesm
Copy link
Member Author

hannesm commented Apr 28, 2025

Thanks @samoht. From a git grep in the public opam-repository, it looks like {>= "2.5.7" & < "3.0.0" | >= "5.1.1" & < "6.0.0"}

Details
opam-repository$ git grep '"cohttp' | grep '.v0'
packages/async_rpc_websocket/async_rpc_websocket.v0.15.0/opam:  "cohttp_async_websocket" {>= "v0.15" & < "v0.16"}
packages/async_rpc_websocket/async_rpc_websocket.v0.15.0/opam:  "cohttp-async"           {>= "2.5.6" & < "3.0.0" | >= "5.0.0"}
packages/async_rpc_websocket/async_rpc_websocket.v0.16.0/opam:  "cohttp_async_websocket" {>= "v0.16" & < "v0.17"}
packages/async_rpc_websocket/async_rpc_websocket.v0.16.0/opam:  "cohttp-async"           {>= "2.5.7" & < "3.0.0" | >= "5.1.1" & < "6.0.0"}
packages/async_rpc_websocket/async_rpc_websocket.v0.17.0/opam:  "cohttp_async_websocket" {>= "v0.17" & < "v0.18"}
packages/async_rpc_websocket/async_rpc_websocket.v0.17.0/opam:  "cohttp-async"           {>= "2.5.7" & < "3.0.0" | >= "5.1.1" & < "6.0.0"}
packages/bonsai/bonsai.v0.15.0/opam:  "cohttp-async"             {>= "2.5.6" & < "3.0.0" | >= "5.0.0"}
packages/bonsai/bonsai.v0.15.1/opam:  "cohttp-async"             {>= "2.5.6" & < "3.0.0" | >= "5.0.0"}
packages/bonsai/bonsai.v0.16.0/opam:  "cohttp-async"             {>= "2.5.7" & < "3.0.0" | >= "5.1.1" & < "6.0.0"}
packages/bonsai/bonsai.v0.17.0/opam:  "cohttp-async"                {>= "2.5.7" & < "3.0.0" | >= "5.1.1" & < "6.0.0"}
packages/cohttp_async_websocket/cohttp_async_websocket.v0.15.0/opam:  "cohttp" {>= "2.5.6" & < "6.0.0~"}
packages/cohttp_async_websocket/cohttp_async_websocket.v0.15.0/opam:  "cohttp-async" {>= "2.5.6" & < "3.0.0" | >= "5.0.0" & < "6.0.0~"}
packages/cohttp_async_websocket/cohttp_async_websocket.v0.16.0/opam:  "cohttp"          {>= "2.5.6"}
packages/cohttp_async_websocket/cohttp_async_websocket.v0.16.0/opam:  "cohttp-async"    {>= "2.5.7" & < "3.0.0" | >= "5.1.1" & < "6.0.0~"}
packages/cohttp_async_websocket/cohttp_async_websocket.v0.17.0/opam:  "cohttp"          {>= "2.5.6"}
packages/cohttp_async_websocket/cohttp_async_websocket.v0.17.0/opam:  "cohttp-async"    {>= "2.5.7" & < "3.0.0" | >= "5.1.1" & < "6.0.0"}
packages/cohttp_static_handler/cohttp_static_handler.v0.15.0/opam:  "cohttp-async" {>= "2.5.6" & < "3.0.0" | >= "5.0.0"}
packages/cohttp_static_handler/cohttp_static_handler.v0.16.0/opam:  "cohttp-async" {>= "2.5.7" & < "3.0.0" | >= "5.1.1" & < "6.0.0"}
packages/cohttp_static_handler/cohttp_static_handler.v0.17.0/opam:  "cohttp-async" {>= "2.5.7" & < "3.0.0" | >= "5.1.1" & < "6.0.0"}
packages/sentry/sentry.v0.10.1/opam:  "cohttp" {>= "2.0.0"}
packages/sentry/sentry.v0.10.1/opam:  "cohttp-async" {>= "2.0.0"}
packages/sentry/sentry.v0.11.0/opam:  "cohttp" {>= "2.0.0"}
packages/sentry/sentry.v0.11.0/opam:  "cohttp-async" {>= "2.0.0"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants