Skip to content

Fix CI #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
os:
- macos-latest
- ubuntu-latest
- windows-latest
# - windows-latest
ocaml-compiler:
- "4.14"
- "5.2"
Expand All @@ -21,6 +21,5 @@ jobs:
with:
ocaml-compiler: ${{ matrix.ocaml-compiler }}
- run: opam install . --deps-only --with-test
- run: opam install core_bench core_unix
- run: opam exec -- dune build
- run: opam exec -- dune runtest
4 changes: 4 additions & 0 deletions benchmarks/dune
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
(:standard -w -58))))

(executables
(enabled_if
(not %{env:CI=false}))
(libraries
re
core
Expand All @@ -17,6 +19,8 @@
(names benchmark))

(executable
(enabled_if
(not %{env:CI=false}))
(name compare)
(modules compare)
(libraries
Expand Down
5 changes: 3 additions & 2 deletions dune-project
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
(lang dune 3.12)
(lang dune 3.15)

(name re)

Expand All @@ -23,7 +23,8 @@
(depends
(ocaml (>= 4.12.0))
(ppx_expect :with-test)
(ounit2 :with-test))
(ounit2 :with-test)
(js_of_ocaml :with-test))
(description "
Pure OCaml regular expressions with:
* Perl-style regular expressions (module Re.Perl)
Expand Down
14 changes: 14 additions & 0 deletions lib_test/expect/dune
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
ppx_expect.config
ppx_expect.config_types
ppx_expect
ppx_expect_common
base
str
ppx_inline_test.config)
Expand All @@ -15,6 +16,19 @@
(preprocess
(pps ppx_expect)))

;; ppx_expect v16 depends on ppx_expect.common
(subdir
ppx_expect_common
(library
(name ppx_expect_common)
(enabled_if
(< %{ocaml_version} 5.0))
(libraries (re_export ppx_expect.common)))
(library
(name ppx_expect_common)
(enabled_if
(>= %{ocaml_version} 5.0))))

;; this hackery is needed because ppx_expect itself uses re, therefore we need to mangle
;; the library name

Expand Down
3 changes: 2 additions & 1 deletion re.opam
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,11 @@ license: "LGPL-2.1-or-later WITH OCaml-LGPL-linking-exception"
homepage: "https://github.com/ocaml/ocaml-re"
bug-reports: "https://github.com/ocaml/ocaml-re/issues"
depends: [
"dune" {>= "3.12"}
"dune" {>= "3.15"}
"ocaml" {>= "4.12.0"}
"ppx_expect" {with-test}
"ounit2" {with-test}
"js_of_ocaml" {with-test}
"odoc" {with-doc}
]
build: [
Expand Down
Loading