Thread safety #574
Open
Thread safety #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since other thread can create automaton states with an index larger the size of the position array, we compare at each step that the current index fits when running the automaton.
This is slow, but we can check that TSan reports no data race.
Basically, we are building an automaton lazily. We use double-checked locking to avoid acquiring a mutex when traversing a part of the automaton which has already been computed. The memory model ensures that we see either an uninitialized state or the initialized state. If we see the initialized state, we can just proceed. Otherwise, we acquire a mutex and update the state after checking this has not been done by another thread.
Use a fake implementation of mutexes and domains in this case to avoid a dependency on the threads library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes RE thread-safe with OCaml 5.
We want the overhead to be minimal while matching a string, and allow concurrent string matching. Basically, RE works by traversing an automaton which is built lazily. So, there is no locking while traversing the automaton, but only when it is updated.
For that, we take advantage of the fact that double-checked locking is sound under the OCaml memory-model. When we reach a part of the automaton that has not been initialized yet, we acquire a mutex to update it. All the datastructures used to build this automaton are protected by this mutex.