Signature help should not appear on the function name #1997
+174
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucccyo
force-pushed
the
sig_help_fun_name
branch
from
ab6f404 to
afd3a00
Compare
Contributor
|
Thank you for the PR |
Lucccyo
force-pushed
the
sig_help_fun_name
branch
from
9b82c93 to
25ac81b
Compare
voodoos
reviewed
Dec 5, 2025
| active_param = Option.value ~default:0 s.active_param; | ||
| active_signature = 0 | ||
| } | ||
| if (Msource.compare_logical (Msource.get_logical source position) (Msource.get_logical source s.function_position)) < 0 then None |
Collaborator
There was a problem hiding this comment.
This line being too long hints that the api for Msource.compare_logical is not great.
Let's have a Msource.compare_position : Msource.position -> Msource.position -> int instead.
You can also put that as a guard in the pattern matching, I think it will make the intent clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merlin displays a
signature-helpresponse on every part of a function call, including the function name.However,
signature-helpshould appear only on function parameters.The
signature-helpcommand should not return an answer for function names.