Add reproduction for some locate issues #1930
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ddickstein I added reproduction for the issues you listed when they were missing. |
xvw
reviewed
May 7, 2025
xvw
reviewed
May 7, 2025
| set_levels saved; | ||
| let loc = sarg.pexp_loc in | ||
| { | ||
| exp_desc = Texp_ident |
There was a problem hiding this comment.
WDYT about extracting the exp_desc in a dedicated variable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
locate-typebrings me to wrong type #1594 is due to Dune not generating configuration force the source of a copied fileThe last commit should fix both #1580 and #1588.