Update nested dune test to emulate calling dune build more closely
#12916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Maybe best to extract the utility out so we don't have to build it every time we run the test? |
Leonidas-from-XIV
force-pushed
the
nested-dune-call-part-0
branch
from
347ae5b to
68f2a5a
Compare
Collaborator
Author
|
Sure; I've moved it to |
Alizter
reviewed
Dec 11, 2025
Leonidas-from-XIV
force-pushed
the
nested-dune-call-part-0
branch
from
ea87007 to
13da4e0
Compare
Leonidas-from-XIV
force-pushed
the
nested-dune-call-part-0
branch
2 times, most recently
from
20dbb28 to
9656f28
Compare
The way the test is implemented, the code testing dune is always calling the (outside, Dune unter test) via its absolute path. This change, extracted from ocaml#12902 calls Dune via absolute path but wraps it in an utility where argv[0] is set to "dune" instead of the absolute path, more closely resembling a call to `dune build` instead of (a hypothetical) `/usr/bin/dune build`. Signed-off-by: Marek Kubica <[email protected]>
This avoids having to quote variables in the content. Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Leonidas-from-XIV
force-pushed
the
nested-dune-call-part-0
branch
from
9656f28 to
9a454ea
Compare
Alizter
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the test is implemented, the code testing dune is always calling the (outside, Dune unter test) via its absolute path.
This change, extracted from #12902 calls Dune via absolute path but wraps it in an utility where argv[0] is set to "dune" instead of the absolute path, more closely resembling a call to
dune buildinstead of (a hypothetical)/usr/bin/dune build.