Update tutorial to use autolocking #12859
Conversation
|
Unfortunately I had to remove a lot of output where the solution was displayed, because with autolocking the solution is not displayed anymore. I've opened #12865 to discuss how to improve the user experience in that case, giving a users a way to figure out which packages + versions were selected by the solver. |
Leonidas-from-XIV
force-pushed
the
update-pkg-mgmt-tutorial-autolock
branch
from
c435b75 to
eb5bcf5
Compare
| packages are published in the opam-repository occasionally, Dune might pick | ||
| different solutions over time. |
There was a problem hiding this comment.
I think this isn't a very robust account of the dynamics at play. Whether or not new packages are published, different builds can end up with different dependencies based on a number of factors: the system run on, the which repos are pinned, whether or not the user has had connectivity, whether packages are marked unavailable, etc. I think it's better to just describe the core need that motivates locking. And you do that in the next paragraph. So maybe this sentence can be removed?
Leonidas-from-XIV
force-pushed
the
update-pkg-mgmt-tutorial-autolock
branch
2 times, most recently
from
aad05d3 to
15a0e31
Compare
Leonidas-from-XIV
changed the title
Sudha247
left a comment
Sudha247
left a comment
There was a problem hiding this comment.
Good to have this updated!
Some remarks below. I also found mentions of dune pkg lock in howto/use-opam-alongside-dune-package-management.rst and howto/homebrew-package.rst which we might want to check.
Leonidas-from-XIV
force-pushed
the
update-pkg-mgmt-tutorial-autolock
branch
from
9e4d89d to
598ff93
Compare
|
Is this ready for another review? Or is it still being worked on? |
|
Yes, I welcome some reviews so maybe we can get it merged in time for 3.21. |
Leonidas-from-XIV
force-pushed
the
update-pkg-mgmt-tutorial-autolock
branch
from
598ff93 to
eebe860
Compare
| longer than usual, as the dependencies need to be built first. Subsequent | ||
| builds where all dependencies have been built before will be just as fast as | ||
| before. | ||
| Since this is the first time we have run the build system after enabling package |
There was a problem hiding this comment.
It seems this is getting folded in the collapsible dune-workspace. I'm not sure that is intended?
Sudha247
left a comment
Sudha247
left a comment
There was a problem hiding this comment.
I've gone through the tutorial once to validate we get the expected results, and we do. I think this is good to go.
shonfeder
left a comment
shonfeder
left a comment
There was a problem hiding this comment.
I have a few more suggestions, but they don't need to blocking.
|
|
||
| which will download and install the new dependencies and build our project as | ||
| before. | ||
| This will recongnize that the project depends on new packages. Thus it will |
There was a problem hiding this comment.
What does 'this' refer to here?
There was a problem hiding this comment.
Good question. I've clarified it and rewrote some paragraphs that also started with "This" to be more precise and hopefully less repetitive.
| (lock_dir | ||
| (repositories overlay1 upstream1)) |
There was a problem hiding this comment.
Ugh, that is awkward :( seems to be leaking implementation details, but that can be addressed in some followup.
Leonidas-from-XIV
force-pushed
the
update-pkg-mgmt-tutorial-autolock
branch
from
d939e9d to
5925442
Compare
Signed-off-by: Marek Kubica <[email protected]>
Leonidas-from-XIV
force-pushed
the
update-pkg-mgmt-tutorial-autolock
branch
from
5925442 to
ff00b58
Compare
3 participants
Updates to the tutorial to use autolocking (plus explain how to manually lock).
Closes #12796