-
Notifications
You must be signed in to change notification settings - Fork 456
Use DUNE_CACHE_ROOT instead of XDG_CACHE_HOME in toolchains/revstore caches #12858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rgrinberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation is fine but the name db isn't particularly suggestive of anything. I'd suggest a name like rules or build.
Also, it would be good to have a test that just prints all o these paths with/without configuration.
Gotta say I disagree here. Sure the current name isn't the best, but changing that would mean breaking everyone's cache, not just people who have
Sure! |
|
When you say break, you mean we force people to repopulate the cache by rerunning the rules? If so, then this is something that happens regularly. You can keep the current name if you prefer though. All of this is fairly invisible to users anyway. |
885dcc4 to
0190e3f
Compare
Signed-off-by: Ambre Austen Suhamy <[email protected]>
Signed-off-by: Ambre Austen Suhamy <[email protected]>
Signed-off-by: Ambre Austen Suhamy <[email protected]>
…dune_util` Signed-off-by: Ambre Austen Suhamy <[email protected]>
0190e3f to
c1597d4
Compare
There is now |
src/dune_pkg/rev_store.ml
Outdated
| (* Why do we create the directory in all cases, and not just when enabled? *) | ||
| Path.mkdir_p path; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move that into the enabled branch
Signed-off-by: Ambre Austen Suhamy <[email protected]>
Signed-off-by: Ambre Austen Suhamy <[email protected]>
Signed-off-by: Ambre Austen Suhamy <[email protected]>
Signed-off-by: Ambre Austen Suhamy <[email protected]>
c1597d4 to
7fc775d
Compare
|
I'm aware this needs not just a changelog entry (which it has), but a mention in the actual docs. I put off making that section until the back-and-forth between this PR and #11612 was well and truly ended, and so it will land in a subsequent PR. |
This PR is an alternate version of #11612, implementing the 'breaking' option discussed here
It fixes #11584, and helps (but does not fix) #11585.
To recap:
DUNE_CACHE_ROOTdefaults toXDG/dune/dbXDG/dune/DUNE_CACHE_ROOTorXDG/dune/dbDUNE_CACHE_ROOT/dborXDG/dune/dbXDG/dune/git-repoonlyDUNE_CACHE_ROOT/git-repoorXDG/dune/git-repoXDG/dune/rev_storeonlyDUNE_CACHE_ROOT/rev_storeorXDG/dune/rev_storeXDG/dune/toolchainsonlyDUNE_CACHE_ROOT/toolchainsorXDG/dune/toolchains