feat: Add support for multi-part exercices #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikmd
changed the title
erikmd
reviewed
Jul 5, 2022
…lti-part exercise
JossyYila
commented
Jul 11, 2022
JossyYila
commented
Jul 11, 2022
| @@ -455,6 +455,7 @@ let update_tabs meta exo ans = | |||
| update_answer_tab ans.Answer.solution | |||
|
|
|||
| let () = | |||
| print_string ("Test Show exo stV : \n"); | |||
There was a problem hiding this comment.
remove or comment this print
JossyYila
commented
Jul 11, 2022
| @@ -334,7 +334,7 @@ module Conversions (Json: JSON_CODEC) = struct | |||
| | Exercise_index None -> | |||
| get ["exercise-index.json"] | |||
|
|
|||
| | Exercise (Some token, id) -> | |||
| | Exercise (Some token, id) -> print_string ("Api_multipart_2_ : \n"); | |||
There was a problem hiding this comment.
remove or comment the print_string
…multipart_file build
Still TODO @JossyYila: - don't hardcode the demo-multi.json anymore - don't generate the demo-multi/*.json anymore - remove the warnings *after* understanding the bugs they helped spotting typically: File "src/app/learnocaml_exercise_main.ml", line 229, characters 56-61: 229 | retrieve (Learnocaml_api.Exercise_index tok) >>= fun (index,l) -> ^^^^^ Warning 27 [unused-var-strict]: unused variable index. File "src/app/learnocaml_exercise_main.ml", line 229, characters 62-63: 229 | retrieve (Learnocaml_api.Exercise_index tok) >>= fun (index,l) -> ^ Warning 27 [unused-var-strict]: unused variable l.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements backend of the feature requests #331.
@erikmd I would like to notify that the server returns a 500 error when you want to connect with a teacher token.
Checklist
Note to maintainers
Fix #…if need be)