Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Skip network tests #777

Closed
wants to merge 5 commits into from

Conversation

create2000
Copy link
Contributor

This is a work-in-progress for skipping tests when network is unavailable

@create2000
Copy link
Contributor Author

Hello @patricoferris -- I created a draft PR. In this PR i only added some [Eio_linux.run](url) ~fallback:skip to some functions. I want to know if that's okay, and if it is, how do i proceed with adding the skip feature to Mdx.

Also, after adding the Eio_linux.run ~fallback:skip, i still get this

...
@@ -133,6 +129,5 @@ Signalling an exited child does nothing:
   in
   ignore (Promise.await (Process.exit_status child) : Unix.process_status);
   Process.signal child Sys.sigkill;;
-FOO=bar
-- : unit = ()
+Exception: Failure "io_uring is not available (permission denied)".

How do i proceed?

PS: Is it okay to keep on contributing even after the Outreachy contribution stage period is over? I'd love to.

@talex5
Copy link
Collaborator

talex5 commented Oct 29, 2024

This PR seems to change every file in the entire project (see https://github.com/ocaml-multicore/eio/pull/777/files). Possibly some kind of line-endings problem?

@create2000
Copy link
Contributor Author

Hello @talex5 @patricoferris --I don't know where the other corrections came in from but I have created a new PR and have added only the changed file. You can find it here

@create2000 create2000 mentioned this pull request Oct 29, 2024
@create2000 create2000 closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants