Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions llvm/lib/Target/X86/X86CallingConv.td
Original file line number Diff line number Diff line change
Expand Up @@ -445,14 +445,19 @@ def RetCC_X86_64_OCaml : CallingConv<[
CCIfType<[i8, i16, i32], CCPromoteToType<i64>>,

// Every function preserves the necessary function arguments
CCIfType<[i64], CCAssignToReg<[R14, RAX, RBX, RDI, RSI, RDX, RCX, R8, R9, R12, R13]>>,
CCIfType<[i64], CCAssignToReg<[R14, R15, RAX, RBX, RDI, RSI, RDX, RCX, R8, R9, R12, R13]>>,

CCIfType<[f32, f64], CCAssignToReg<[
XMM0, XMM1, XMM2, XMM3, XMM4, XMM5, XMM6, XMM7,
XMM8, XMM9, XMM10, XMM11, XMM12, XMM13, XMM14, XMM15
]>>
]>;

def RetCC_X86_64_OCaml_C_Call : CallingConv<[
CCIfType<[i64], CCAssignToReg<[R14, R15]>>,

CCDelegateTo<RetCC_X86_64_C>
]>;

defm X86_32_RegCall :
X86_RegCall_base<RC_X86_32_RegCall>;
Expand Down Expand Up @@ -509,6 +514,7 @@ def RetCC_X86_64 : CallingConv<[

// Handle OCaml calls
CCIfCC<"CallingConv::OCaml", CCDelegateTo<RetCC_X86_64_OCaml>>,
CCIfCC<"CallingConv::OCaml_C_Call", CCDelegateTo<RetCC_X86_64_OCaml_C_Call>>,

// Otherwise, drop to normal X86-64 CC
CCDelegateTo<RetCC_X86_64_C>
Expand Down Expand Up @@ -725,9 +731,8 @@ def CC_X86_64_OCaml : CallingConv<[
// (registers containing pointers to data structures maintained by the
// runtime) must be preserved through the run of the program. To ensure LLVM
// doesn't mess with them, they are explicitly threaded through function calls
// and returns. These are R14 and R15. Note that R15 isn't listed since it is
// not implemented yet.
CCIfType<[i64], CCAssignToReg<[R14, RAX, RBX, RDI, RSI, RDX, RCX, R8, R9, R12, R13]>>,
// and returns. These are R14 and R15.
CCIfType<[i64], CCAssignToReg<[R14, R15, RAX, RBX, RDI, RSI, RDX, RCX, R8, R9, R12, R13]>>,

CCIfType<[f32, f64], CCAssignToReg<[
XMM0, XMM1, XMM2, XMM3, XMM4, XMM5, XMM6, XMM7,
Expand All @@ -738,7 +743,7 @@ def CC_X86_64_OCaml : CallingConv<[
def CC_X86_64_OCaml_C_Call : CallingConv<[
// OCaml wraps C calls with another function that transfers stack arguments.
// RAX contains the function address, and R12 contains the size of the stack arguments.
CCIfType<[i64], CCAssignToReg<[RAX, R12]>>,
CCIfType<[i64], CCAssignToReg<[R14, R15, RAX, R12]>>,

// Follow C convention normally otherwise
CCDelegateTo<CC_X86_64_C>
Expand Down Expand Up @@ -1173,6 +1178,9 @@ def CSR_NoRegs : CalleeSavedRegs<(add)>;
def CSR_32 : CalleeSavedRegs<(add ESI, EDI, EBX, EBP)>;
def CSR_64 : CalleeSavedRegs<(add RBX, R12, R13, R14, R15, RBP)>;

// R14 and R15 are used as return registers, so they aren't callee saved.
def CSR_64_OCaml_C_Call : CalleeSavedRegs<(add RBX, R12, R13, RBP)>;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use sub ?


def CSR_64_SwiftError : CalleeSavedRegs<(sub CSR_64, R12)>;
def CSR_64_SwiftTail : CalleeSavedRegs<(sub CSR_64, R13, R14)>;

Expand Down
4 changes: 4 additions & 0 deletions llvm/lib/Target/X86/X86RegisterInfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,8 @@ X86RegisterInfo::getCalleeSavedRegs(const MachineFunction *MF) const {
case CallingConv::HiPE:
case CallingConv::OCaml:
return CSR_NoRegs_SaveList;
case CallingConv::OCaml_C_Call:
return CSR_64_OCaml_C_Call_SaveList;
case CallingConv::AnyReg:
if (HasAVX)
return CSR_64_AllRegs_AVX_SaveList;
Expand Down Expand Up @@ -426,6 +428,8 @@ X86RegisterInfo::getCallPreservedMask(const MachineFunction &MF,
case CallingConv::HiPE:
case CallingConv::OCaml:
return CSR_NoRegs_RegMask;
case CallingConv::OCaml_C_Call:
return CSR_64_OCaml_C_Call_RegMask;
case CallingConv::AnyReg:
if (HasAVX)
return CSR_64_AllRegs_AVX_RegMask;
Expand Down