Skip to content

(arm64) fix save/restore for vec128 #3979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2025

Conversation

gretay-js
Copy link
Contributor

When saving / restoring float registers in the runtime, using 128 bits instead of 64, because the registers may be used for SIMD.

The PR simply changes d0 to q0 and update stack offsets in (hopefully) all relevant places.

Copy link
Contributor

@TheNumbat TheNumbat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stack.h:81 also needs updating (and CI fixed) but otherwise looks good

@gretay-js gretay-js marked this pull request as ready for review May 9, 2025 20:50
@gretay-js gretay-js merged commit b3f5baa into ocaml-flambda:main May 12, 2025
27 checks passed
Gbury pushed a commit to Gbury/flambda-backend that referenced this pull request May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants