Propagate Debugging Identifiers through the Middle End #3967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiessimon
added
flambda2
bclement-ocp
reviewed
May 5, 2025
Comment on lines
1197
to
1199
| (* CR sspies: We can probably find a better | ||
| [Flambda_debug_uid.t] for these extra variables. However, | ||
| propagating it here seems non-trivial. *) |
There was a problem hiding this comment.
FYI variables with Name_mode.in_types never exist at runtime (roughly speaking, they are used when we have information on something that doesn't have a name in the current scope), it's probably not useful for them to have a debug uid.
There was a problem hiding this comment.
Ah, that's very useful to know! I've updated the comment here and in a few other places to indicate that Flambda_debug_uid.none is correct here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #3942. It propagates the debugging identifiers from Lambda through Flambda.