Remove old x86 Directives #3948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiessimon
commented
Apr 30, 2025
spiessimon
commented
Apr 30, 2025
This was referenced Apr 30, 2025
Closed
spiessimon
force-pushed
the
new-directives-x86-remove-old-ones
branch
from
7bf1756 to
c73e03b
Compare
mshinwell
requested changes
May 8, 2025
mshinwell
approved these changes
May 23, 2025
spiessimon
force-pushed
the
new-directives-x86-remove-old-ones
branch
from
dd85f4f to
61052ed
Compare
Gbury
pushed a commit
to Gbury/flambda-backend
that referenced
this pull request
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the old x86 directives in favor of the new ones. This notably includes using the new logic for printing directives instead of the existing x86 logic for printing directives. The changes that were observed in the emitted assembly code are summarized in PR #3951.