Skip to content

Remove IRC-related fields from Reg.t #3835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 11, 2025
Merged

Remove IRC-related fields from Reg.t #3835

merged 5 commits into from
Apr 11, 2025

Conversation

xclerc
Copy link
Contributor

@xclerc xclerc commented Apr 10, 2025 •
edited
Loading

As per title, IRC will use maps (in the state
to store the values).

@xclerc xclerc added the backend label Apr 10, 2025
@xclerc xclerc marked this pull request as ready for review April 10, 2025 12:41
@xclerc
Copy link
Contributor Author

xclerc commented Apr 10, 2025

(There is a bit of information duplication in
the IRC state, but that should be addressed
in a follow-up to keep this pull request easy
to review.)

@xclerc xclerc mentioned this pull request Apr 11, 2025
Merged
spiessimon
spiessimon approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@spiessimon spiessimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments below, but this PR looks good to me. It might be worth clarifying when a register is in the respective maps and when the functions that access the maps without checks can be called safely.

@xclerc
Copy link
Contributor Author

xclerc commented Apr 11, 2025

(The failure is due to the infamous arm64 bug.)

@xclerc xclerc merged commit e5ea115 into main Apr 11, 2025
26 checks passed
@xclerc xclerc deleted the reg-remove-fields branch April 11, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiessimon spiessimon spiessimon approved these changes

@gretay-js gretay-js gretay-js approved these changes

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xclerc @gretay-js @spiessimon