Skip to content

Statefulness and visibility axes #3774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 12, 2025
Merged

Statefulness and visibility axes #3774

merged 8 commits into from
Apr 12, 2025

Conversation

dkalinichenko-js
Copy link
Contributor

@dkalinichenko-js dkalinichenko-js commented Apr 1, 2025 •
edited
Loading

Rebase of #3098 with updated naming: statefulness going stateless < observing < stateful and access going immutable < read < read_write. Similarly to the defaulting for yielding, stateless implies portable, immutable implies contended, and read implies shared. Also adds a new kind atomic_immutable_data.

Subsequent PRs will update Stdlib, Capsule API, etc, to use those.

@dkalinichenko-js dkalinichenko-js added the modes Work on modes. There's some overlap with the `multicore` label, but not strictly so. label Apr 1, 2025
@dkalinichenko-js dkalinichenko-js requested a review from lpw25 April 1, 2025 13:04
@dkalinichenko-js dkalinichenko-js force-pushed the dkalinichenko/local-implies-yielding branch from 65e2665 to 1bc5a60 Compare April 1, 2025 15:56
@dkalinichenko-js dkalinichenko-js force-pushed the dkalinichenko/statefulness-modes branch from c11c2af to af68841 Compare April 1, 2025 15:56
Base automatically changed from dkalinichenko/local-implies-yielding to main April 1, 2025 17:26
@dkalinichenko-js dkalinichenko-js force-pushed the dkalinichenko/statefulness-modes branch 2 times, most recently from b65c400 to 596080d Compare April 3, 2025 16:59
@dkalinichenko-js dkalinichenko-js changed the title Statefulness and access axes Statefulness and visibility axes Apr 3, 2025
@dkalinichenko-js
Copy link
Contributor Author

Renamed Access to Visibility.

lpw25
lpw25 reviewed Apr 9, 2025
View reviewed changes
Copy link
Collaborator

@lpw25 lpw25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed all the tests

@dkalinichenko-js dkalinichenko-js force-pushed the dkalinichenko/statefulness-modes branch from 022b4c9 to 53fbbb7 Compare April 10, 2025 17:27
lpw25
lpw25 approved these changes Apr 11, 2025
View reviewed changes
Copy link
Collaborator

@lpw25 lpw25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One error message suggestion, then I think this is good to go.

@dkalinichenko-js dkalinichenko-js enabled auto-merge (squash) April 12, 2025 23:26
@dkalinichenko-js dkalinichenko-js merged commit cb54980 into main Apr 12, 2025
26 checks passed
@dkalinichenko-js dkalinichenko-js deleted the dkalinichenko/statefulness-modes branch April 12, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpw25 lpw25 lpw25 approved these changes

Assignees
No one assigned
Labels
modes Work on modes. There's some overlap with the `multicore` label, but not strictly so.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkalinichenko-js @lpw25 @d-kalinichenko