Support modules of non-legacy modes #3759
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riaqn
added
typing
modes
lukemaurer
reviewed
Mar 31, 2025
riaqn
force-pushed
the
modal-module
branch
4 times, most recently
from
eefebc5 to
2f89dc6
Compare
riaqn
commented
Apr 8, 2025
goldfirere
reviewed
Apr 29, 2025
lukemaurer
reviewed
Apr 30, 2025
riaqn
commented
Apr 30, 2025
goldfirere
reviewed
Apr 30, 2025
riaqn
commented
May 1, 2025
lukemaurer
reviewed
May 2, 2025
lukemaurer
reviewed
May 6, 2025
riaqn
force-pushed
the
minor-fix-modes
branch
2 times, most recently
from
7ac004d to
b89cf95
Compare
|
I've resolved my Discussions on this PR |
lukemaurer
approved these changes
Jun 13, 2025
riaqn
force-pushed
the
modal-module
branch
2 times, most recently
from
6a6f258 to
3030775
Compare
riaqn
force-pushed
the
modal-module
branch
2 times, most recently
from
e24a7fe to
9af2554
Compare
|
@lukemaurer can you review the new commits: post rebase fix include should rebase modalities change how extension level affects modalities improve comments change error message |
riaqn
commented
Jun 27, 2025
lukemaurer
reviewed
Jul 7, 2025
lukemaurer
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3757 and #3758 and #3824
This PR adds the support for modules of non-legacy modes. Functor parameter and body are still fixed to be legacy.
TODO:
The room for improvement shouldn't block preliminary review and discussion. In particular, changes to the existing tests seem correct, and can serve as a good starting point.