Skip to content

Update "Local allocation" documentation #3479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Feb 24, 2025
Merged

Update "Local allocation" documentation #3479

merged 21 commits into from
Feb 24, 2025

Conversation

riaqn
Copy link
Contributor

@riaqn riaqn commented Jan 15, 2025

Based on #3475 , and potentially #3471 (in which case, a short sentence will be added to the documentation)

But can be reviewed without merging them.

This PR updates the local allocation documentation by decoupling modes from allocation. In particular, it usese stack_ syntax.

@riaqn riaqn marked this pull request as ready for review January 16, 2025 16:10
@goldfirere
Copy link
Collaborator

Instead of making suggestions here in the PR, I just went ahead and made some edits on top of what you started here, @riaqn. Could you please review my commit? If you're happy with that, then we can merge this.

Copy link
Contributor Author

@riaqn riaqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edits - they look great. Could you look at my comments below? If you concur, I will make the edits.

@riaqn
Copy link
Contributor Author

riaqn commented Jan 27, 2025

This is blocked by #3471 , because I really want the complete story about stack and primitives.

@riaqn
Copy link
Contributor Author

riaqn commented Jan 31, 2025

We are also blocked by the resolution of #3106

@riaqn
Copy link
Contributor Author

riaqn commented Feb 12, 2025

We are now blocked by the ocamlformat support for #3106 - but it's also fine to tell users to use the old syntax, and fix ocamlformat later.

Copy link
Collaborator

@goldfirere goldfirere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just try to get this out the door. I don't feel strongly on any of my points, and I think this is a nice improvement over the status quo. Happy with small changes you might make to resolve discussions. Thanks!

@riaqn riaqn enabled auto-merge (squash) February 24, 2025 17:45
@riaqn riaqn merged commit 04fb351 into main Feb 24, 2025
24 checks passed
@riaqn riaqn deleted the stack-doc branch February 24, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants