Use more restrictive options to make curl safer
#136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marek Kubica <[email protected]>
Leonidas-from-XIV
changed the title
curl safer
smorimoto
approved these changes
Nov 18, 2024
|
Both features have been available in curl over a decade ago and should be fine. |
gridbugs
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Lgtm! These flags are also part of the install command on https://rustup.rs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by @smorimoto's #126 I think these options make sense to add in the script:
--tlsv1.2will require TLS 1.2+ (but also allow 1.3) thus prevents it from using older, less secure TLS versions--proto '=https'will prevent redirecting to HTTP. Since we download from GitHub and where GitHub redirects to is outside of our control I think there is a point in making sure it will fail if it redirects to a HTTP location.Both our server and Github support TLSv1.2, the question is more whether our users have
curlthat support these options. Mycurlhas them and the one in Alpine as well, so maybe this is fine without a feature check?WDYT?