-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdint and zmq packages #33
base: master
Are you sure you want to change the base?
Conversation
packages/stdint-android.0.3.0/opam
Outdated
build-doc: [ "ocaml" "setup.ml" "-doc" ] | ||
depends: [ | ||
"ocaml-android" | ||
"base-bytes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implied in ocaml-android
packages/stdint-android.0.3.0/opam
Outdated
depends: [ | ||
"ocaml-android" | ||
"base-bytes" | ||
"ocamlfind" {>= "1.5"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implied in ocaml-android
packages/zmq-android.4.0-8/findlib
Outdated
@@ -0,0 +1 @@ | |||
zmq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed as opam does not know about -toolchain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
without such findlib files for zmq-android and stdint, ocamlfind can't find this packages when I compile my code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn't make any sense, ocamlfind does not use these "findlib" files. Are you sure there was no other difference? Can you check one more time please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no findlib files in opam-repository anymore. ocaml/opam-repository#9328
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I remove them too -- on clear installation I don't seen problems without findlib files.
@@ -0,0 +1 @@ | |||
stdint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed as opam does not know about -toolchain
packages/zmq-android.4.0-8/opam
Outdated
depends: [ | ||
"ocaml-android" | ||
"conf-zmq-android" | ||
"ocamlfind" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implied in ocaml-android
packages/zmq-android.4.0-8/opam
Outdated
"ocaml-android" | ||
"conf-zmq-android" | ||
"ocamlfind" | ||
"base-unix" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implied in ocaml-android
"ocamlbuild" {build} | ||
] | ||
conflicts: [ | ||
"ocaml-zmq" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a reason for this conflict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm steal this opam file from author of package, and just modified related part's. This line written by author of zmq.
@@ -0,0 +1,3 @@ | |||
Virtual package relying on zmq library installation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not use virtual packages for native dependencies in cross-toolchains
] | ||
depends: [ | ||
"ocaml-android" | ||
"conf-zmq-android" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this dependency, you should add a depext for the zmq package in MXE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is MXE means http://mxe.cc/ ?
I don't use android-ndk -- I'm sit on yocto/bitbake with plain gcc cross-compiler suite, so I can't use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, MXE is not relevant, forget this part.
No description provided.