Skip to content

Show error when target is not visible in the Window section #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnation3406 merged 1 commit into from
Aug 26, 2025
Merged

Show error when target is not visible in the Window section #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/RequestGroupComposition/RequestGroup.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<custom-field
v-model="requestGroup.name"
field="name"
:label="getFromObject(formConfig, ['requestGroup', 'name', 'label'], 'Name')"
:label="getFromObject(formConfig, ['requestGroup', 'name', 'label'], 'Request Name')"
:desc="getFromObject(formConfig, ['requestGroup', 'name', 'desc'], '')"
:hide="getFromObject(formConfig, ['requestGroup', 'name', 'hide'], false)"
:errors="errors.name"
Expand Down
7 changes: 6 additions & 1 deletion src/components/RequestGroupComposition/Window.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,12 @@ export default {
},
computed: {
topLevelErrors: function() {
return extractTopLevelErrors(this.errors);
let combinedError = extractTopLevelErrors(this.errors);
Copy link
Member Author

@jnation3406 jnation3406 Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.errors comes from a prop passed down from the parent, and will have errors on specific fields. The airmassData can also have an error (if there is an error with visibility), in which case this code below should include that in the error list shown at the top of this component.

// If showAirmass is false, it means that the airmassData is actually an error message returned from the endpoint
if (!this.showAirmass) {
combinedError = _.concat(combinedError, extractTopLevelErrors(this.airmassData));
}
return combinedError;
}
},
methods: {
Expand Down