Stop caching visibility for whole semester for nonsidereal targets wi… #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th eccentricity >= 1 to avoid numerical instability in orbits
added 2 commits
July 9, 2025 06:17
jchate6
requested changes
Jul 9, 2025
jchate6
left a comment
jchate6
left a comment
There was a problem hiding this comment.
Minor change in how we log the warning would be helpful, unless you have a particular reason for not wanting that.
I think I follow the logic and the code makes sense. I don't see any obvious problems.
My only concerns are that if this does still fail for some reason, the user still won't have any idea why. For them it just won't ever schedule and we won't notice unless we go digging for it in the logs. It would be nice if there were some way to get this error (or just the fact that there IS an error) to the user in cases where the scheduler throws an exception like this.
I also understand this is likely outside the scope of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…th eccentricity >= 1 to avoid numerical instability in orbits
This adds in the permanent logging of the MovingViolation number, and then prevents the semester-length visibility caching for targets with eccentricity >= 1. Those targets will instead be cached per-request rather than per-target with just their window specified in the request, which should align it with what happens in the Observation Portal better.
This is currently running on the dev network and works with the high eccentricity request that was failing before.