Fix run-hook.cmd script directory resolution on Unix#484
Open
Fix run-hook.cmd script directory resolution on Unix#484
Conversation
When Claude Code invokes run-hook.cmd via sh -c, BASH_SOURCE is unavailable and $0 resolves to the cwd rather than the script location. This causes the hook to look for session-start in the wrong directory, producing a SessionStart:startup hook error on every session. Use CLAUDE_PLUGIN_ROOT (set by Claude Code as an env var) when available, falling back to the existing $0-based resolution for direct invocation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run-hook.cmduses${BASH_SOURCE[0]:-$0}to find its own directory, but when Claude Code invokes the command viash -c,BASH_SOURCEis unavailable and$0resolves to the cwd instead of the script's locationexec bash "${SCRIPT_DIR}/session-start"to look in the wrong directory, producingSessionStart:startup hook erroron every session start$CLAUDE_PLUGIN_ROOT(which Claude Code sets as an env var) when available, falling back to the existing$0-based resolution for direct invocationHow it was diagnosed
SCRIPT_DIRresolving to the user's cwd (e.g.~/Source/some-project) rather than the plugin cache directorysession-startscript never executed — the wrapper failed before reaching itTest plan
SessionStart:startup hook errorshould appearrun-hook.cmd session-startfrom CLI should still work (fallback path)🤖 Generated with Claude Code