Skip to content

fix(skills): restore worktree step in brainstorming workflow #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qishaoyumu wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −4
Open

fix(skills): restore worktree step in brainstorming workflow #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions skills/brainstorming/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ You MUST create a task for each of these items and complete them in order:
3. **Propose 2-3 approaches** — with trade-offs and your recommendation
4. **Present design** — in sections scaled to their complexity, get user approval after each section
5. **Write design doc** — save to `docs/plans/YYYY-MM-DD-<topic>-design.md` and commit
6. **Transition to implementation** — invoke writing-plans skill to create implementation plan
6. **Set up worktree** — invoke using-git-worktrees to create isolated implementation workspace
7. **Transition to implementation** — invoke writing-plans skill to create implementation plan

## Process Flow

Expand All @@ -40,6 +41,7 @@ digraph brainstorming {
"Present design sections" [shape=box];
"User approves design?" [shape=diamond];
"Write design doc" [shape=box];
"Set up worktree (using-git-worktrees)" [shape=box];
"Invoke writing-plans skill" [shape=doublecircle];

"Explore project context" -> "Ask clarifying questions";
Expand All @@ -48,11 +50,12 @@ digraph brainstorming {
"Present design sections" -> "User approves design?";
"User approves design?" -> "Present design sections" [label="no, revise"];
"User approves design?" -> "Write design doc" [label="yes"];
"Write design doc" -> "Invoke writing-plans skill";
"Write design doc" -> "Set up worktree (using-git-worktrees)";
"Set up worktree (using-git-worktrees)" -> "Invoke writing-plans skill";
}
```

**The terminal state is invoking writing-plans.** Do NOT invoke frontend-design, mcp-builder, or any other implementation skill. The ONLY skill you invoke after brainstorming is writing-plans.
**The terminal state is invoking writing-plans.** Do NOT invoke any implementation skill directly. After design approval, invoke using-git-worktrees for workspace isolation, then invoke writing-plans.

## The Process

Expand Down Expand Up @@ -82,6 +85,10 @@ digraph brainstorming {
- Use elements-of-style:writing-clearly-and-concisely skill if available
- Commit the design document to git

**Workspace isolation:**
- Invoke the using-git-worktrees skill to create an isolated workspace for implementation
- All subsequent implementation work happens in this worktree

**Implementation:**
- Invoke the writing-plans skill to create a detailed implementation plan
- Do NOT invoke any other skill. writing-plans is the next step.
Expand Down
2 changes: 1 addition & 1 deletion skills/using-git-worktrees/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ Ready to implement auth feature
## Integration

**Called by:**
- **brainstorming** (Phase 4) - REQUIRED when design is approved and implementation follows
- **brainstorming** (Step 6) - REQUIRED after writing design doc, before invoking writing-plans
- **subagent-driven-development** - REQUIRED before executing any tasks
- **executing-plans** - REQUIRED before executing any tasks
- Any skill needing isolated workspace
Expand Down