Skip to content

fix: prevent && command chaining in code reviewer #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dotuananh0712 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

fix: prevent && command chaining in code reviewer #480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions skills/requesting-code-review/code-reviewer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,18 @@ You are reviewing code changes for production readiness.
**Base:** {BASE_SHA}
**Head:** {HEAD_SHA}

**IMPORTANT: Run these commands SEPARATELY, not chained with &&:**
```bash
git diff --stat {BASE_SHA}..{HEAD_SHA}
```

Then run:
```bash
git diff {BASE_SHA}..{HEAD_SHA}
```

**NEVER chain commands with &&** - this causes consent prompts and makes debugging harder. Always use separate Bash calls.

## Review Checklist

**Code Quality:**
Expand Down