Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased/decreased chemical concentration in location #973

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seger
Copy link
Member

@seger seger commented Jan 17, 2025

New patterns requested by Xenbase curators.

@matentzn
Copy link
Collaborator

This pattern has been discussed a few times, since http://purl.obolibrary.org/obo/upheno/patterns-dev/abnormalConcentrationOfChemicalEntity.yaml exists, we will admit it, but I think if we really want take the opportunity here to very clearly define under which exact circumstances we should use "abnormal level of" vs "abnormal concentration of".

@matentzn matentzn requested a review from rays22 January 18, 2025 09:12
@seger
Copy link
Member Author

seger commented Jan 31, 2025

@matentzn The Xenbase curators say that "abnormal level of" suffices instead of "abnormal concentration of", so we can withdraw this request.

@rays22
Copy link
Contributor

rays22 commented Feb 4, 2025

@matentzn The Xenbase curators say that "abnormal level of" suffices instead of "abnormal concentration of", so we can withdraw this request.

@seger , @matentzn
"Level" is very ambiguously when people describe phenotypes. It may mean "amount", "total amount", or "concentration" depending on the context.

PATO:0001163 decreased concentration is a subclass of PATO:0001997 decreased amount so we can stop here.
However, there are valid cases when "decreased concentration" would be more appropriate to describe a phenotype than "decreased amount". For example, when "decreased amount" is intended to mean "decreased total amount". In those case "decreased concentration" does not necessarily lead to "decreased total amount". OK, we do not have "total amount" (as a subclass of "amount") or a "decreased total amount" (as a subclass of "decreased amount") in PATO yet, but I think we should to distinguish "decreased total amount" and "decreased concentration" phenotypes.

Similar reasoning should apply to "increased amount" and "increased concentration".

I have no objections adding these templates if they are needed for data annotation.

Let me know if you want me to proceed with the review.

@seger
Copy link
Member Author

seger commented Feb 6, 2025

@rays22 @matentzn I'm in favor of adding the templates. That way, we can capture what the curators originally intended with those annotations. Thank you.

@sbello
Copy link

sbello commented Feb 6, 2025 via email

Copy link
Contributor

@rays22 rays22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add two or three phenotype examples in the description section of each template?

@@ -0,0 +1,45 @@
pattern_name: abnormallyDecreasedConcentrationOfChemicalEntityInLocation
pattern_iri: http://purl.obolibrary.org/obo/upheno/patterns-dev/abnormallyDecreasedConcentrationOfChemicalEntityInLocation.yaml
description: "An abnormal decrease in concentration of a chemical, like sodium, in a location, like the blood."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seger
Could you please ask the curators for some phenotype examples when using the more general "level"-pattern (as in abnormallyDecreasedLevelOfChemicalEntityInLocation) would miss distinguishing some phenotypes that are based on concentration measurements?

We need to provide examples of justified cases for this template.
It may be confusing that some phenotype categories that use the
abnormallyDecreasedLevelOfChemicalEntityInLocation or the
abnormallyIncreasedLevelOfChemicalEntityInLocation
patterns are based on concentration measurements.

However, as @sbello noted, the term "level" (used as a synonym of PATO "amount") has been intended to include both "concentration" and non-concentration-type amount qualities (like "total amount"). The meaning of "level" in uPheno is removed from the strict primary measurement type (concentration- or other measurement). When the quantitative observation/measurement is interpreted, the original dimensions are lost and, the phenotype is interpreted on a relative scale that includes abnormally decreased or abnormally increased (and compared to a reference).
See for example the EQs for these phenotype terms:

Technically all of these phenotypes are based on concentration measurements. It is not typically feasible to measure (quickly and in a non-invasive way) the total amount of sodium in the blood of mouse and human, so we do not loose any granularity by using the more general "level" pattern (as far as I know).

I think there could be justified cases for the more specific "concentration" patterns, but we need two or three examples in the description of this pattern so that we can help curators decide how and when to use it.

@@ -0,0 +1,45 @@
pattern_name: abnormallyIncreasedConcentrationOfChemicalEntityInLocation
pattern_iri: http://purl.obolibrary.org/obo/upheno/patterns-dev/abnormallyIncreasedConcentrationOfChemicalEntityInLocation.yaml
description: "An abnormal increase in concentration of a chemical, like sodium, in a location, like the blood."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please ask the curators for two or three phenotype examples when using the more general "level"-pattern (as in abnormallyIncreasedLevelOfChemicalEntityInLocation) would miss distinguishing some phenotypes that are based on concentration measurements from other types (e.g. total amount) of measurements?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants