-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added morphology and related traits #214
Changes from 3 commits
a3f5b78
00dc56a
e492f32
a3787f3
fafe205
8f8e053
5e2f7fc
feff0ed
2d1b920
dabe4f0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -4167,6 +4167,22 @@ OBA:2040170 GO:0030431 sleep PATO:0000001 quality | |||
OBA:2040171 sleep duration trait GO:0030431 sleep PATO:0001309 duration | ||||
OBA:2040172 GO:0030431 sleep PATO:0001005 latency | ||||
OBA:2040173 GO:0030431 sleep PATO:0002325 onset quality | ||||
OBA:2050100 telomere length GO:0000781 chromosome, telomeric region PATO:0000122 length | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There is already a term OBA:0003784 that has the same logical definition, so please drop OBA:2050100 from the table. |
||||
OBA:2050101 chin morphology trait UBERON:0008199 chin PATO:0000051 morphology | ||||
OBA:2050102 heart wall thickness UBERON:0037144 wall of heart PATO:0000915 thickness | ||||
OBA:2050103 hip bone size UBERON:0008202 bone of hip region PATO:0000117 size | ||||
OBA:2050104 ganglion thickness UBERON:0000045 ganglion PATO:0000915 thickness | ||||
OBA:2050105 cranial vault morphology trait UBERON:0004339 vault of skull PATO:0000051 morphology | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There is already a term OBA:VT0000076 that has the same logical definition, so please drop OBA:2050105 from the table. |
||||
OBA:2050106 forehead morphology trait UBERON:0008200 forehead PATO:0000051 morphology | ||||
OBA:2050107 internal carotid artery thickness UBERON:0001532 internal carotid artery PATO:0000915 thickness | ||||
OBA:2050108 carotid artery thickness UBERON:0005396 carotid artery segment PATO:0000915 thickness | ||||
OBA:2050109 superior temporal gyrus thickness UBERON:0002769 superior temporal gyrus PATO:0000915 thickness | ||||
OBA:2050110 retinal layer thickness UBERON:0001781 layer of retina PATO:0000915 thickness | ||||
OBA:2050111 retinal nerve fibre layer thickness UBERON:0001793 nerve fiber layer of retina PATO:0000915 thickness | ||||
OBA:2050112 facial hair thickness UBERON:0010171 strand of hair of face PATO:0000915 thickness | ||||
OBA:2050113 LDL particle size GO:0034362 low-density lipoprotein particle PATO:0000117 size low-density lipoprotein particle size | ||||
OBA:2050114 VLDL particle size GO:0034361 very-low-density lipoprotein particle PATO:0000117 size very-low-density lipoprotein particle size | ||||
OBA:2050115 HDL particle size GO:0034364 high-density lipoprotein particle PATO:0000117 size high-density lipoprotein particle size | ||||
OBA:2060179 body coordination efficacy NBO:0000351 body coordination PATO:0015002 process efficacy | ||||
OBA:2060180 limb coordination efficacy NBO:0000342 limb coordination PATO:0015002 process efficacy | ||||
OBA:2060181 upper limb coordination efficacy NBO:0000346 upper limb coordination PATO:0015002 process efficacy | ||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remove this
src/mappings/oba-efo.sssom.tsv
version from the PR, because this version of the table has fewer lines than the OBA Ontology Development (GWAS, EFO, VT) gsheet.Did you follow the 'Updating SSSOM mapping files' section of the Local development workflows with OBA?
This tsv should agree with the OBA Ontology Development (GWAS, EFO, VT) gsheet, but it does not.