Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make is-loki-running include types in the package #500

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

igorbej
Copy link
Contributor

@igorbej igorbej commented Feb 15, 2024

This PR fixes the issue where the type definitions are missing when installing the package from npm.

Co-authored-by: Tomas Echeverri <[email protected]>
@@ -16,7 +16,8 @@
},
"license": "MIT",
"files": [
"src"
"src",
"*.d.ts"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add !*.d.ts to the .npmignore? @oblador

loki/.npmignore

Lines 1 to 6 in 2d833f0

*
!*.js
!bin/*
!src/**/*
src/**/*.spec.js
src/**/fixtures

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda weird to have both, I think that since the migration to a monorepo this file would be ignored

@oblador oblador merged commit 9ecc607 into oblador:master Mar 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants