scrolling for table headers option (for mobile devices)

objectscript · Jan 8, 2015 · 3c15380 · 3c15380
1 parent 3beff2b
commit 3c15380
Show file tree

Hide file tree

Showing 4 changed files with 49 additions and 15 deletions.
diff --git a/example/index.html b/example/index.html
@@ -104,6 +104,7 @@
             //, triggerEvent: "touchstart" // all "click" events will be replaced by this event
             //, caption: "My table" // if set, table basic caption will be replaced by this text
             , showSummary: true // show summary by columns
+            , enableHeadersScrolling: true // enable scrolling both for table and headers
             //, conditionalFormattingOn: true // enable conditional formatting rules
             //, drillDownTarget: "<dashboard name>" // undocumented, deepSee only
         };

diff --git a/readme.md b/readme.md
@@ -56,6 +56,7 @@ var setup = { // Object that contain settings. Any setting may be missed.
         [ , caption: "My table" // if set, table basic caption will be replaced by this text ]
         [ , showSummary: true // show summary by columns ]
         [ , conditionalFormattingOn: true // pass false to turn off conditional formatting ]
+        [ , enableHeadersScrolling: false // enable scrolling both for table and headers. Useful for mobile devices. ]
         [ , drillDownTarget: "<dashboard name>" // deepSee only - dashboard to open ]
     },
     lp = new LightPivotTable(setup);

diff --git a/source/css/LightPivot.css b/source/css/LightPivot.css
@@ -174,9 +174,9 @@
     /*border-bottom: none;*/
 }
 
-.lpt .lpt-leftHeader table {
-    margin-bottom: 10em;
-}
+/*.lpt .lpt-leftHeader table {*/
+    /*margin-bottom: 10em;*/
+/*}*/
 
 /* lpt-dataWait */
 .lpt .lpt-hoverMessage {
@@ -189,4 +189,17 @@
     -moz-transition: opacity 1s ease;
     -o-transition: opacity 1s ease;
     transition: opacity 1s ease;
+}
+
+.lpt-scrollable-y {
+    overflow-y: auto !important;
+}
+.lpt-scrollable-x {
+    overflow-x: auto !important;
+}
+.lpt-scrollable-x::-webkit-scrollbar {
+    display: none;
+}
+.lpt-scrollable-y::-webkit-scrollbar {
+    display: none;
 }
diff --git a/source/js/PivotView.js b/source/js/PivotView.js
@@ -369,8 +369,9 @@ PivotView.prototype.recalculateSizes = function (container) {
             containerHeight = container.offsetHeight,
             mainHeaderWidth = headerContainer.offsetWidth,
             hasVerticalScrollBar = tableBlock.scrollHeight > containerHeight - headerH,
-            addExtraTopHeaderCell = tTableHead.offsetWidth > topHeader.offsetWidth,
-            addExtraLeftHeaderCell = lTableHead.offsetHeight > containerHeight - headerH,
+            //addExtraTopHeaderCell = tTableHead.offsetWidth > topHeader.offsetWidth,
+            addExtraLeftHeaderCell = lTableHead.offsetHeight > containerHeight - headerH
+                && this.SCROLLBAR_WIDTH > 0,
             cell, tr, cellWidths = [], columnHeights = [], i;
 
         headerContainer.style.width = headerW + "px";
@@ -403,12 +404,12 @@ PivotView.prototype.recalculateSizes = function (container) {
         tableBlock.style.height = containerHeight - headerH + "px";
         headerContainer.style.height = headerH + "px";
 
-        if (addExtraTopHeaderCell) {
-            tTableHead.childNodes[0].appendChild(cell = document.createElement("th"));
-            cell.rowSpan = tTableHead.childNodes.length;
-            cell.style.paddingLeft = headerW + "px"; // lucky random
-            cell["_extraCell"] = true;
-        }
+        //if (false && addExtraTopHeaderCell) {
+        //    tTableHead.childNodes[0].appendChild(cell = document.createElement("td"));
+        //    cell.rowSpan = tTableHead.childNodes.length;
+        //    cell.style.width = this.SCROLLBAR_WIDTH + "px"; // lucky random
+        //    cell["_extraCell"] = true;
+        //}
 
         if (addExtraLeftHeaderCell) {
             tr = document.createElement("tr");
@@ -421,10 +422,12 @@ PivotView.prototype.recalculateSizes = function (container) {
                 if (cell["__i"] > 5) _["_"]();
             });
             tr["_extraTr"] = true;
-            leftHeader.className = "lpt-leftHeader bordered";
+            leftHeader.className = leftHeader.className.replace(/\sbordered/, "")
+                + " bordered";
             cell.colSpan = lTableHead.childNodes.length;
-            cell.textContent = "_"; // cheating
-            cell.style.lineHeight = headerH + "px"; // lucky random
+            cell.style.height = this.SCROLLBAR_WIDTH + "px";
+            //cell.textContent = "_"; // cheating
+            //cell.style.lineHeight = headerH + "px"; // lucky random
         }
 
         for (i in tableTr.childNodes) {
@@ -629,13 +632,29 @@ PivotView.prototype.renderRawData = function (data) {
     }
 
     tableBlock.addEventListener("scroll", function () {
+        if (tableBlock._ISE) { tableBlock._ISE = false; return; }
         topHeader.scrollLeft = tableBlock.scrollLeft;
         leftHeader.scrollTop = tableBlock.scrollTop;
+        topHeader._ISE = true; leftHeader._ISE = true; // ignore scroll event
     });
 
-    tableBlock.className = "lpt-tableBlock";
     leftHeader.className = "lpt-leftHeader";
     topHeader.className = "lpt-topHeader";
+    if (this.controller.CONFIG.enableHeadersScrolling) {
+        leftHeader.className = leftHeader.className + " lpt-scrollable-y";
+        topHeader.className = topHeader.className + " lpt-scrollable-x";
+        leftHeader.addEventListener("scroll", function () {
+            if (leftHeader._ISE) { leftHeader._ISE = false; return; }
+            tableBlock.scrollTop = leftHeader.scrollTop;
+            tableBlock._ISE = true;
+        });
+        topHeader.addEventListener("scroll", function () {
+            if (topHeader._ISE) { topHeader._ISE = false; return; }
+            tableBlock.scrollLeft = topHeader.scrollLeft;
+            tableBlock._ISE = true;
+        });
+    }
+    tableBlock.className = "lpt-tableBlock";
     pivotHeader.className = "lpt-header";
     pivotTopSection.className = "lpt-topSection";
     pivotBottomSection.className = "lpt-bottomSection";