HW1 updated#29
Open
RostislavKorst wants to merge 1 commit into
Open
Conversation
obabichev
reviewed
Apr 6, 2021
| rel="stylesheet" | ||
| href="https://cdnjs.cloudflare.com/ajax/libs/semantic-ui/2.4.1/semantic.min.css" | ||
| /> | ||
| <link rel="icon" href="../favicon.ico" /> |
Owner
There was a problem hiding this comment.
Я думаю, favicon.ico лучше также поместить в папку public, тогда при сборке эта иконка будет просто перекопирована со всей папкой public в собранное приложение
obabichev
reviewed
Apr 6, 2021
| console.log(tasks); | ||
| const BoardTaskList = () => { | ||
| return ( | ||
| <> |
Owner
There was a problem hiding this comment.
Скорей всего в итоге Фрагмент здесь будет нужен, но здесь и сейчас, пока из BoardTaskList возвращается только массив элементов, Фрагмент скорее избыточен
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Здравствуйте!
Я немного поправил код для 1 дз,чтобы убрать хардкод. Однако я не понимаю, как лучше для задания отображать вложенные задачи(как лучше обрабатывать таски и сабтаски и какой компонент использовать). Могли бы вы, пожалуйста, подсказать в каком направлении дальше двигаться?