-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Fix Docker options after removing oasis-deposit #471
Conversation
✅ Deploy Preview for oasisprotocol-sapphire-paratime canceled.
|
2d84b1f
to
c3a27a7
Compare
c3a27a7
to
9541ab6
Compare
Can you pass the |
Yeah, I tried both |
What about overriding |
That is super-hacky and harder to maintain. In the case of our CI, funding 2 accounts vs. 5 doesn't result in a noticeable speed improvement to warrant the extra maintenance burden IMO :) |
It is for cases when a specific dApp CI tests require non-default accounts to be funded, or none at all. |
Yeah, in that case overriding the entrypoint is an option. |
Note that I haven't found a way to pass the script arguments to the end of the Docker run command from GitHub Actions, but the nice part is that they don't really matter, since the test mnemonic and 5 accounts is already the default 🤷♂️
Closes #465.