Initial work to implement Sapphire snap connection #431
Conversation
✅ Deploy Preview for oasisprotocol-sapphire-paratime canceled.
|
CedarMist
force-pushed
the
CedarMist/sapphire-snap
branch
from
47c82fc to
9d74f0f
Compare
| @@ -43,6 +44,7 @@ export function isLegacyProvider<T extends object>( | |||
|
|
|||
| export interface SapphireWrapOptions { | |||
| fetcher: KeyFetcher; | |||
There was a problem hiding this comment.
Options object is optional. When provided, TS requires fetcher, but we should be able just to set enableSapphireSnap flag. As fetcher always defaults to new KeyFetcher() should it now be fetcher: KeyFetcher | undefined; ?
clients/js/src/provider.ts
Outdated
| @@ -80,10 +82,10 @@ export function isWrappedEthereumProvider<P extends EIP2696_EthereumProvider>( | |||
| * @param options (optional) Re-use parameters from other providers | |||
| * @returns Sapphire wrapped provider | |||
| */ | |||
| export function wrapEthereumProvider<P extends EIP2696_EthereumProvider>( | |||
| export async function wrapEthereumProvider<P extends EIP2696_EthereumProvider>( | |||
There was a problem hiding this comment.
Does it affect all integrations? For example I don't see ether-v6 is relying on wrapEthereumProvider. It has it's own logic. Do we plan to apply the same code in a few places, or share some snap utils across packages?
I guess for ether-v6 we should call notifySapphireSnap right after https://github.com/oasisprotocol/sapphire-paratime/blob/main/integrations/ethers-v6/src/index.ts#L96
clients/js/src/provider.ts
Outdated
| params: { | ||
| id: transactionData, | ||
| ephemeralSecretKey: hexlify(secretKey), | ||
| peerPublicKey: peerPublicKey.key, |
buberdds
force-pushed
the
CedarMist/sapphire-snap
branch
3 times, most recently
from
3d04a4c to
853e9b9
Compare
| public override readonly epoch: number | undefined; | ||
|
|
||
| private cipher: deoxysii.AEAD; | ||
| private key: Uint8Array; // Stored for curious users. | ||
| public secretKey: Uint8Array; // Stored for curious users. |
There was a problem hiding this comment.
That's not a key we need, added ephemeralkey.
buberdds
force-pushed
the
CedarMist/sapphire-snap
branch
3 times, most recently
from
29746d8 to
bc5b8bf
Compare
buberdds
force-pushed
the
CedarMist/sapphire-snap
branch
from
bc5b8bf to
8844dbe
Compare
clients/js/src/provider.ts
Outdated
| @@ -99,7 +101,7 @@ export function wrapEthereumProvider<P extends EIP2696_EthereumProvider>( | |||
| // if we do this, don't then re-wrap the send() function | |||
| // only wrap the send() function if there was a request() function | |||
|
|
|||
| const request = makeSapphireRequestFn(upstream, filled_options); | |||
| const request = await makeSapphireRequestFn(upstream, filled_options); | |||
There was a problem hiding this comment.
I have reverted a change of making it all async, because async part can be handled in proxy
fixes #389
This provides the decryption keys to snap.
Warning
If an RPC server pretends to implement the MetaMask snap protocol it could trick users into revealing the transaction encryption key.
For this reason, we have to explicitly enable Snap support in the dApp, by passing the
enableSapphireSnapoption.Usage:
This must only be done if the dApp is sure that the provider it's connecting to is MetaMask.
Next PRs handled by Sapphire team:
wallet_invokeSnap